#1898 Move header files consumed by both server and client to special folder
Closed: Fixed 2 years ago Opened 6 years ago by mzidek.

We have some header files consumed by both server and client code. Header files consumed by the client code should remain minimal and not include anything unnecessary for the client. We have warning at the beginning of these headers to avoid adding functions and macros needed by the server (but not needed by the client):

+/* CAUTION:
+ * This file is also used in sss_client (pam, nss). Therefore it has to be
+ * minimalist and cannot include DEBUG macros or header file util.h.
+ */

The warning message can be easily overseen especially in larger header files. Moving these headers to special folder (something like src/shared) would make it harder to oversee the fact that we work with headers shared with the client. It would be also easier to identify these headers when looking for them in the src tree.


Before starting on this ticket ask for details on the sssd-devel list.

keywords: => easyfix
milestone: NEEDS_TRIAGE => SSSD 1.12 beta
rhbz: => 0

We have more urgent tasks on our plate..

changelog: =>
mark: => 0
milestone: SSSD 1.14 beta => SSSD 1.15 beta
sensitive: => 0

Metadata Update from @mzidek:
- Issue set to the milestone: SSSD Future releases (no date set yet)

2 years ago

Metadata Update from @jhrozek:
- Custom field design_review reset (from 0)
- Custom field mark reset (from 0)
- Custom field patch reset (from 0)
- Custom field review reset (from 0)
- Custom field sensitive reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue close_status updated to: None
- Issue tagged with: easyfix

2 years ago

Metadata Update from @jhrozek:
- Custom field design_review reset (from false)
- Custom field mark reset (from false)
- Custom field patch reset (from false)
- Custom field review reset (from false)
- Custom field sensitive reset (from false)
- Custom field testsupdated reset (from false)

2 years ago

Metadata Update from @jhrozek:
- Custom field design_review reset (from false)
- Custom field mark reset (from false)
- Custom field patch reset (from false)
- Custom field review reset (from false)
- Custom field sensitive reset (from false)
- Custom field testsupdated reset (from false)
- Issue close_status updated to: Fixed
- Issue set to the milestone: SSSD 1.15.4 (was: SSSD Future releases (no date set yet))
- Issue status updated to: Closed (was: Open)

2 years ago

Metadata Update from @jhrozek:
- Custom field design_review reset (from false)
- Custom field mark reset (from false)
- Custom field patch reset (from false)
- Custom field review reset (from false)
- Custom field sensitive reset (from false)
- Custom field testsupdated reset (from false)
- Issue set to the milestone: SSSD 1.16.0 (was: SSSD 1.15.4)

2 years ago

Login to comment on this ticket.

Metadata