#1870 wrong failure handler in sdap_get_map
Closed: Fixed None Opened 5 years ago by jhrozek.

Found by Coverity:

77        if (map[i].def_name && !map[i].name) {
  78            DEBUG(SSSDBG_CRIT_FAILURE,
  79                  ("Failed to retrieve value for %s\n", map[i].opt_name));

const: At condition "ret != 0", the value of "ret" must be equal to 0.

dead_error_condition: The condition "ret != 0" cannot be true.
  80            if (ret != EOK) {

CID 10011 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement "do {
_talloc_free((void *...".
  81                talloc_zfree(map);
  82                return EINVAL;
  83            }
  84        }

We should always return EINVAL in that case.


Fields changed

owner: somebody => jhrozek
patch: 0 => 1
status: new => assigned

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.10.0
rhbz: => 0

resolution: => fixed
status: assigned => closed

Moving to 1.10 beta where the ticket was actually fixed.

changelog: =>
milestone: SSSD 1.10.0 => SSSD 1.10 beta

Metadata Update from @jhrozek:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.10 beta

2 years ago

Login to comment on this ticket.

Metadata