#1864 Bad comparisons in checks found by new Coverity instance
Closed: Fixed None Opened 5 years ago by jhrozek.

The new Coverity instance found several cases where we check for a different variable name after allocation or a different operation, such as here:

385                rdomain = talloc_strdup(tmp_ctx, default_domain);
386                if (default_domain == NULL) {
387                    DEBUG(SSSDBG_OP_FAILURE, ("talloc_strdup failed.\n"));
388                    ret = ENOMEM;
389                    goto done;
390                }

This ticket tracks all there problems.


Fields changed

coverity: 10021 => 10021, 10020,10014

Fields changed

coverity: 10021, 10020,10014 => 10021, 10020,10014,10013

Fields changed

owner: somebody => jhrozek
patch: 0 => 1
status: new => assigned

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.10.0
rhbz: => 0

Fields changed

milestone: SSSD 1.10.0 => SSSD 1.10 beta

resolution: => fixed
status: assigned => closed

Metadata Update from @jhrozek:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.10 beta

2 years ago

Login to comment on this ticket.

Metadata