Learn more about these different git repos.
Other Git URLs
In some cases, copy_dir may return negative value which may propagate all the way up and cause the DEBUG messages to print spurious error codes. We should return errno, not -1 here:
701 /* Set the desired mode. Do this explicitly to preserve S_ISGID and 702 * other bits. Do this after chown, because chown is permitted to 703 * reset these bits. */ 704 ret = fchmod(dest_dir_fd, mode); 8. Condition "ret == -1", taking true branch 9. var_tested_neg: Variable "ret" is negative. 705 if (ret == -1) { 10. Condition "debug_level & __debug_macro_newlevel", taking false branch 11. Condition "debug_level == 0", taking true branch 12. Condition "__debug_macro_newlevel & (48 /* 0x10 | 0x20 */)", taking false branch 706 DEBUG(SSSDBG_OP_FAILURE, 707 ("Error setting mode of '%s': %s", 708 dest_dir_path, strerror(ret))); 13. Jumping to label "done" 709 goto done; 710 }
Fields changed
coverity: 10027 => 10027,10026,10025
owner: somebody => jhrozek patch: 0 => 1 status: new => assigned
milestone: NEEDS_TRIAGE => SSSD 1.10.0 rhbz: => 0
milestone: SSSD 1.10.0 => SSSD 1.10 beta
resolution: => fixed status: assigned => closed
Metadata Update from @jhrozek: - Issue assigned to jhrozek - Issue set to the milestone: SSSD 1.10 beta
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/2904
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Login to comment on this ticket.