#1858 ding-libs.dhash: multiple dereferences before null check
Closed: Fixed None Opened 11 years ago by okos.

coverity issues

dhash/dhash.c

 844int hash_entries(hash_table_t *table, unsigned long *count_arg, hash_entry_t **entries_arg)
 845{

deref_ptr: Directly dereferencing pointer "table".
 846    unsigned long count = table->entry_count;
 847    hash_entry_t *entries;
 848    hash_entries_callback_data_t data;
 849

CID 10052 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking "table" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
 850    if (!table) return HASH_ERROR_BAD_TABLE;




 769int hash_keys(hash_table_t *table, unsigned long *count_arg, hash_key_t **keys_arg)
 770{

deref_ptr: Directly dereferencing pointer "table".
 771    unsigned long count = table->entry_count;
 772    hash_key_t *keys;
 773    hash_keys_callback_data_t data;
 774

CID 10053 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking "table" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
 775    if (!table) return HASH_ERROR_BAD_TABLE;




 800int hash_values(hash_table_t *table, unsigned long *count_arg, hash_value_t **values_arg)
 801{

deref_ptr: Directly dereferencing pointer "table".
 802    unsigned long count = table->entry_count;
 803    hash_value_t *values;
 804    hash_values_callback_data_t data;
 805

CID 10054 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking "table" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
 806    if (!table) return HASH_ERROR_BAD_TABLE;

Fields changed

patch: 0 => 1

Fields changed

patch: 0 => 1

Fields changed

patch: 0 => 1

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0.1

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0.1

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0.1

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

owner: somebody => okos

Fields changed

owner: somebody => okos

Fields changed

owner: somebody => okos

resolution: => fixed
status: new => closed
_comment0: * master: 736ccbe7930f443d7d381d93d8cf89665345f36a => 1365609533645741

resolution: => fixed
status: new => closed
_comment0: * master: 736ccbe7930f443d7d381d93d8cf89665345f36a => 1365609533645741

resolution: => fixed
status: new => closed
_comment0: * master: 736ccbe7930f443d7d381d93d8cf89665345f36a => 1365609533645741

Metadata Update from @okos:
- Issue assigned to okos
- Issue set to the milestone: Tools 1.0.1

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2900

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Log in to comment on this ticket.

Metadata