#173 INI Parser should report failure to open a file in the error_list
Closed: Fixed None Opened 10 years ago by sgallagh.

If you attempt to call config_from_file() on a file that you do not have read privilege on, config_from_file properly returns a nonzero error code, but it does not add an error to the error_list indicating that the failure was due to being unable to open the file. Printing the error_list thus does not indicate what failure occurred, making it difficult to determine what action needs to be taken to correct the problem.

As a relevant example, attempting to start the SSSD as a non-root user (who does not have permission to read the sssd.conf) results in the error message

[sssd] [read_config_file] (0): Parse error reading configuration file [/etc/sssd/sssd.conf]

The SSSD code then calls print_file_parsing_errors(stderr, error_list); but no output is printed to the screen.


I will think about what can be done about this.
The errors list is designed to contain only errors related to parsing of the file since it is caller choice to ignore them or not.

May be the way to go is to create a function that will return ini error string if the parsing returned an error and have not read the file at all.

Fields changed

milestone: SSSD 0.6.0 => SSSD 0.7.0

With the new functionality of config_from_fd() this issue becomes less relevant thus can be postponed.

milestone: SSSD 0.7.0 => SSSD Deferred

This is needed for the ELAPI troubleshooting and as we said earlier we want to move the permission checking into the ini interface. So we need this change for 1.3.

proposed: => 1.3

File open error can now be captured in metadata.

Commit: e495687

resolution: => fixed
status: new => closed

Fields changed

fixedin: => 1.2.0
milestone: SSSD Deferred => SSSD 1.2.0

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to dpal
- Issue set to the milestone: SSSD 1.2.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1215

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata