#1516 krb5_mod_ccname should cancel the transaction at one place only
Closed: Fixed None Opened 7 years ago by jhrozek.

Reported by Coverity:

 165    ret = sysdb_set_user_attr(sysdb, name, attrs, mod_op);
At conditional (13): "ret != 0" taking the true branch.
 166    if (ret != EOK) {
At conditional (14): "debug_level & __debug_macro_newlevel" taking the true branch.
At conditional (15): "debug_timestamps" taking the true branch.
At conditional (16): "debug_microseconds" taking the true branch.
 167        DEBUG(6, ("Error: %d (%s)\n", ret, strerror(ret)));
CID 13083: Unchecked return value (CHECKED_RETURN)Calling function "sysdb_transaction_cancel" without checking return value (as is done elsewhere 51 out of 56 times).
No check of the return value of "sysdb_transaction_cancel(sysdb)".
 168        sysdb_transaction_cancel(sysdb);
 169        goto done;
 170    }

We're also calling sysdb_transaction_cancel in the done label as well -- and we should only call it there.


Fields changed

owner: somebody => jhrozek
status: new => assigned

Fields changed

patch: 0 => 1

master: 6b758f3

milestone: NEEDS_TRIAGE => SSSD 1.9.0 RC1
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @jhrozek:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.9.0 RC1

2 years ago

Login to comment on this ticket.

Metadata