#1491 Consolidate functions that make a realm upper-case
Closed: Fixed None Opened 6 years ago by jhrozek.

There are several places in the code that strdup a string and then uppercase the copy. We should consolidate them to one place.

Cscope tag: toupper
   #   line  filename / context / line
   1    108  src/providers/ad/ad_common.c <<ad_get_common_options>>
             realm[i] = toupper(realm[i]);
   2    107  src/providers/ipa/ipa_common.c <<ipa_get_options>>
             realm[i] = toupper(realm[i]);
   3    191  src/providers/ipa/ipa_subdomains.c <<name_to_realm>>
             *p = toupper(*p);
   4     40  src/providers/ldap/sdap_async.c <<make_realm_upper_case>>
             c[0] = toupper(*c);

Fields changed

priority: major => trivial

Fields changed

status: new => assigned
version: 1.8.4 => 1.9.0 beta 3

Fields changed

patch: 0 => 1

Fixed in e4c29d1

milestone: NEEDS_TRIAGE => SSSD 1.9.0 RC1
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @jhrozek:
- Issue assigned to okos
- Issue set to the milestone: SSSD 1.9.0 beta 7

2 years ago

Login to comment on this ticket.

Metadata