#1287 compilation warnings with -O2
Closed: Duplicate None Opened 8 years ago by jhrozek.

There's a handful of compilation warnings with a higher optimization level:

src/db/sysdb_selinux.c: In function 'sysdb_store_selinux_entity':
src/db/sysdb_selinux.c:60:8: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
src/db/sysdb_selinux.c:34:13: note: 'ret' was declared here
src/db/sysdb_selinux.c:105:13: warning: 'dn' may be used uninitialized in this function [-Wuninitialized]
src/db/sysdb_selinux.c:131:20: note: 'dn' was declared here
src/db/sysdb_selinux.c:91:9: warning: 'objectclass' may be used uninitialized in this function [-Wuninitialized]
src/db/sysdb_selinux.c:128:17: note: 'objectclass' was declared here
src/providers/ldap/sdap_async_connection.c: In function 'sdap_cli_resolve_done':
src/providers/ldap/sdap_async_connection.c:1263:8: warning: 'use_tls' may be used uninitialized in this function [-Wuninitialized]
src/providers/proxy/proxy_id.c: In function 'save_group':
src/providers/proxy/proxy_id.c:489:12: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_netgroups.c: In function 'ipa_netgr_process_all':
src/providers/ipa/ipa_netgroups.c:836:18: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_s2n_exop.c: In function 'ipa_s2n_get_user_done':
src/providers/ipa/ipa_s2n_exop.c:408:16: warning: 'retoid' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_s2n_exop.c:582:11: note: 'retoid' was declared here
src/providers/ipa/ipa_s2n_exop.c:408:35: warning: 'retdata' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_s2n_exop.c:583:20: note: 'retdata' was declared here
src/providers/ipa/ipa_s2n_exop.c: In function 'ipa_s2n_get_acct_info_send':
src/providers/ipa/ipa_s2n_exop.c:84:9: warning: 'bv_req' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_s2n_exop.c:532:20: note: 'bv_req' was declared here
src/providers/ipa/ipa_session.c: In function 'ipa_session_handler_done':
src/providers/ipa/ipa_session.c:127:13: warning: 'map_count' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_session.c:127:13: warning: 'maps' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_session.c:120:13: warning: 'default_user' may be used uninitialized in this function [-Wuninitialized]
src/providers/ipa/ipa_session.c:120:13: warning: 'map_order' may be used uninitialized in this function [-Wuninitialized]
src/responder/nss/nsssrv_cmd.c: In function ‘fill_grent’:
src/responder/nss/nsssrv_cmd.c:1886:42: warning: ‘memnum’ may be used uninitialized in this function [-Wuninitialized]
src/responder/nss/nsssrv_services.c: In function ‘setservent_step_done’:
src/responder/nss/nsssrv_services.c:1499:41: warning: ‘res’ may be used uninitialized in this function [-Wuninitialized]
src/responder/nss/nsssrv_services.c: In function ‘fill_service’:
src/responder/nss/nsssrv_services.c:764:26: warning: ‘num’ may be used uninitialized in this function [-Wuninitialized]
src/responder/common/responder_dp.c: In function ‘sss_dp_get_account_msg’:
src/responder/common/responder_dp.c:550:9: warning: ‘dp_method’ may be used uninitialized in this function [-Wuninitialized]
src/responder/pam/pamsrv_cmd.c: In function ‘pam_reply’:
src/responder/pam/pamsrv_cmd.c:624:13: warning: ‘len’ may be used uninitialized in this function [-Wuninitialized]

This is annoying for people who compile with -Werror :-)


Code cleanup task

milestone: NEEDS_TRIAGE => SSSD 1.10.0
priority: major => minor
rhbz: => 0
type: defect => task

Fields changed

keywords: => easyfix

Fields changed

proposed_priority: => Nice to have

Cleaning the 1.10 milestones before putting tickets into it.

milestone: SSSD 1.10.0 => Temp milestone

Moving planned features and bug fixes into the 1.10 bucket.

milestone: Temp milestone => SSSD 1.10.0

Fields changed

milestone: SSSD 1.10.0 => Temp milestone

Moving all the features planned for 1.10 release into 1.10 beta.

milestone: Temp milestone => SSSD 1.10 beta

Fields changed

owner: somebody => okos
status: new => assigned

I tried to compile the source with -O2, and none of these warnings showed up, so I went through all of them and this was already fixed in 8bbf89c which was fix for https://fedorahosted.org/sssd/ticket/1379, duplicate of this.

resolution: => duplicate
status: assigned => closed

For tickets already closed set the field to "Want"

selected: => Want

Metadata Update from @jhrozek:
- Issue assigned to okos
- Issue set to the milestone: SSSD 1.10 beta

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2329

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata