#125 Clean up warnings on RHEL5 build
Closed: Fixed None Opened 14 years ago by sgallagh.

../../server/tools/sss_useradd.c: In function ‘main’:
../../server/tools/sss_useradd.c:386: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_usermod.c: In function ‘main’:
../../server/tools/sss_usermod.c:437: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_groupmod.c: In function ‘main’:
../../server/tools/sss_groupmod.c:373: warning: assignment discards qualifiers from pointer target type
../../sss_client/pam_sss.c: In function 'do_pam_conversation':
../../sss_client/pam_sss.c:293: warning: implicit declaration of function 'strndup'
../../sss_client/pam_sss.c:293: warning: incompatible implicit declaration of built-in function 'strndup'

Here is the list that I got. It is slightly different.

../../server/db/sysdb.c: In function ‘sysdb_init’:
../../server/db/sysdb.c:573: warning: ‘path’ may be used uninitialized in this function
../../server/tools/sss_useradd.c: In function ‘main’:
../../server/tools/sss_useradd.c:386: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_useradd.c:424: warning: ‘ret’ is used uninitialized in this function
../../server/tools/sss_usermod.c: In function ‘main’:
../../server/tools/sss_usermod.c:437: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_groupmod.c: In function ‘main’:
../../server/tools/sss_groupmod.c:373: warning: assignment discards qualifiers from pointer target type
../../sss_client/pam_sss.c: In function 'do_pam_conversation':
../../sss_client/pam_sss.c:235: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:293: warning: implicit declaration of function 'strndup'
../../sss_client/pam_sss.c:293: warning: incompatible implicit declaration of built-in function 'strndup'
../../sss_client/pam_sss.c: In function 'get_pam_items':
../../sss_client/pam_sss.c:422: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:427: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:440: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:445: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:450: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:456: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../sss_client/pam_sss.c:461: warning: dereferencing type-punned pointer will break strict-aliasing rules

Warnings list as of today

../../server/confdb/confdb.c: In function 'get_entry_as_bool':
../../server/confdb/confdb.c:731: warning: unused variable 'endptr'
../../server/python/pysss.c: In function 'py_sss_useradd':
../../server/python/pysss.c:189: warning: passing argument 3 of 'PyArg_ParseTupleAndKeywords' discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'py_sss_userdel':
../../server/python/pysss.c:302: warning: passing argument 2 of 'PyArg_ParseTuple' discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'py_sss_usermod':
../../server/python/pysss.c:431: warning: passing argument 3 of 'PyArg_ParseTupleAndKeywords' discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'py_sss_groupadd':
../../server/python/pysss.c:564: warning: passing argument 3 of 'PyArg_ParseTupleAndKeywords' discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'py_sss_groupdel':
../../server/python/pysss.c:660: warning: passing argument 2 of 'PyArg_ParseTuple' discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'py_sss_groupmod':
../../server/python/pysss.c:773: warning: passing argument 3 of 'PyArg_ParseTupleAndKeywords' discards qualifiers from pointer target type
../../server/python/pysss.c: At top level:
../../server/python/pysss.c:955: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:958: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:961: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:964: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:967: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:970: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:989: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c:996: warning: initialization discards qualifiers from pointer target type
../../server/python/pysss.c: In function 'initpysss':
../../server/python/pysss.c:1017: warning: passing argument 1 of 'Py_InitModule4' discards qualifiers from pointer target type
../../server/python/pysss.c:1022: warning: passing argument 2 of 'PyModule_AddObject' discards qualifiers from pointer target type
../../server/confdb/confdb.c: In function ‘get_entry_as_bool’:
../../server/confdb/confdb.c:731: warning: unused variable ‘endptr’
../../server/tools/sss_useradd.c: In function ‘main’:
../../server/tools/sss_useradd.c:187: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_usermod.c: In function ‘main’:
../../server/tools/sss_usermod.c:116: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_usermod.c:123: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_groupmod.c: In function ‘main’:
../../server/tools/sss_groupmod.c:109: warning: assignment discards qualifiers from pointer target type
../../server/tools/sss_groupmod.c:116: warning: assignment discards qualifiers from pointer target type
../../sss_client/pam_sss.c: In function 'do_pam_conversation':
../../sss_client/pam_sss.c:327: warning: implicit declaration of function 'strndup'
../../sss_client/pam_sss.c:327: warning: incompatible implicit declaration of built-in function 'strndup'

Some of these warnings (such as those related to poptGetArg()) are actually due to the fact that the function type changed at one point from 'const char ' to simply 'char '. Probably the safest thing to do, in order to support both platforms, is copy them if we need them to be 'char *', or make them const if we do not.

doc: => 0
docupdated: => 0
tests: => 0
testsupdated: => 0

Fields changed

milestone: SSSD 1.0 => SSSD 1.0 RC

Fields changed

priority: major => trivial

Fixed in:
9a554bc
93362b5
02bf83e

fixedin: => 0.7.0
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.0 RC

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1167

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata