#1079 SSSD does not sanitize broken memberUID correctly
Closed: Invalid None Opened 12 years ago by jhrozek.

https://bugzilla.redhat.com/show_bug.cgi?id=751314

Description of problem:
When a group contains certain incorrect multivalued memberUID values, SSSD
fails to sanitize the value properly. The memberUID value should contain one
username, so SSSD creates fake users using the broken memberUID as their
username. This causes problems during cache indexing, for example.

Version-Release number of selected component (if applicable):
sssd-1.5.1-66

How reproducible:
always

Steps to Reproduce:
1. Create a group similar to this one:

dn: badmemberuid,ou=Groups,dc=example,dc=com
memberUid: userone,usertwo,userthree
gidNumber: 5418
cn: badmemberuid
objectClass: posixGroup
objectClass: top

2. getent group badmemberuid
3. ldbsearch -H /var/lib/sss/db/cache_example.com.ldb

Actual results:
The commas are not treated as special characters.

Expected results:
The commas are escaped with a '\' to sanitize them.

The DN should be sanitized and upgrades (which index the cache) should perform
fine.

Have a flag (off by default) to detect the wrong format of the values, ignore and record in the logs.

coverity: =>
description: https://bugzilla.redhat.com/show_bug.cgi?id=751314

{{{
Description of problem:
When a group contains certain incorrect multivalued memberUID values, SSSD
fails to sanitize the value properly. The memberUID value should contain one
username, so SSSD creates fake users using the broken memberUID as their
username. This causes problems during cache indexing, for example.

Version-Release number of selected component (if applicable):
sssd-1.5.1-66

How reproducible:
always

Steps to Reproduce:
1. Create a group similar to this one:

dn: badmemberuid,ou=Groups,dc=example,dc=com
memberUid: userone,usertwo,userthree
gidNumber: 5418
cn: badmemberuid
objectClass: posixGroup
objectClass: top

  1. getent group badmemberuid
  2. ldbsearch -H /var/lib/sss/db/cache_example.com.ldb

Actual results:
The commas are not treated as special characters.

Expected results:
The commas are escaped with a '\' to sanitize them.

The DN should be sanitized and upgrades (which index the cache) should perform
fine.
}}}
=> https://bugzilla.redhat.com/show_bug.cgi?id=751314

{{{
Description of problem:
When a group contains certain incorrect multivalued memberUID values, SSSD
fails to sanitize the value properly. The memberUID value should contain one
username, so SSSD creates fake users using the broken memberUID as their
username. This causes problems during cache indexing, for example.

Version-Release number of selected component (if applicable):
sssd-1.5.1-66

How reproducible:
always

Steps to Reproduce:
1. Create a group similar to this one:

dn: badmemberuid,ou=Groups,dc=example,dc=com
memberUid: userone,usertwo,userthree
gidNumber: 5418
cn: badmemberuid
objectClass: posixGroup
objectClass: top

  1. getent group badmemberuid
  2. ldbsearch -H /var/lib/sss/db/cache_example.com.ldb

Actual results:
The commas are not treated as special characters.

Expected results:
The commas are escaped with a '\' to sanitize them.

The DN should be sanitized and upgrades (which index the cache) should perform
fine.
}}}

milestone: NEEDS_TRIAGE => SSSD Deferred
patch: => 0
rhbz: =>
tests: => 0
testsupdated: => 0
upgrade: => 0

Fields changed

blockedby: =>
blocking: =>
changelog: =>
design: =>
design_review: => 0
feature_milestone: =>
fedora_test_page: =>
mark: => 0
review: => 1
selected: =>
sensitive: => 0

Since this ticket was filed more than 5 years ago and nobody needed the fix ever since, we should just close this ticket.

resolution: => wontfix
status: new => closed

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD Patches welcome

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2121

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata