#1074 Potential NULL-dereference in col_find_item_and_do()
Closed: Fixed None Opened 9 years ago by sgallagh.

1564    /* Make sure that there is anything to search */
1565    type &= COL_TYPE_ANY;
At conditional (1): "property_to_find == NULL" taking the true branch.
At conditional (2): "type == 0" taking the false branch.
CID 11087: Dereference after null check (FORWARD_NULL)Comparing "property_to_find" to null implies that "property_to_find" might be null.
Dereferencing null variable "property_to_find".
1566    if (((property_to_find == NULL) && (type == 0)) ||
1567        ((*property_to_find == '\0') && (type == 0))) {
1568        TRACE_ERROR_NUMBER("No item search criteria specified - returning error!", ENOENT);
1569        return ENOENT;
1570    }

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.7.0
owner: dpal => sgallagh

Fields changed

priority: major => minor

This is really strange issue. I see that it is wrong but I added tests to make it crash and it did not. I have a fix but before I submit it I want to be sure I am testing the right thing.

Fixed by:
- f5dbb4ecb9bdf991625d5e48d039a66a765b292c (master)
- b55824ab7821f53e878908dcbddf7cf8a2a78807 (ding_libs-0-1)

owner: sgallagh => dpal

Fields changed

resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to dpal
- Issue set to the milestone: SSSD 1.7.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2116

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.