From ea7839cec593b4a7c678fab52ab864518db6699b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Aug 05 2015 09:28:23 +0000 Subject: mmap: Invalidate initgroups memory cache after any change Initgroups memory cache was invalidated only in case on removed user. it should be invalidated also after changes in group membership. Resolves: https://fedorahosted.org/sssd/ticket/2716 Reviewed-by: Michal Židek --- diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c index 4505f2a..778618e 100644 --- a/src/responder/nss/nsssrv_cmd.c +++ b/src/responder/nss/nsssrv_cmd.c @@ -3939,14 +3939,6 @@ void nss_update_initgr_memcache(struct nss_ctx *nctx, ret, strerror(ret)); } - ret = sss_mmap_cache_initgr_invalidate(nctx->initgr_mc_ctx, - &delete_name); - if (ret != EOK && ret != ENOENT) { - DEBUG(SSSDBG_CRIT_FAILURE, - "Internal failure in memory cache code: %d [%s]\n", - ret, strerror(ret)); - } - /* Also invalidate his groups */ changed = true; } else { @@ -3994,6 +3986,15 @@ void nss_update_initgr_memcache(struct nss_ctx *nctx, ret, strerror(ret)); } } + + to_sized_string(&delete_name, name); + ret = sss_mmap_cache_initgr_invalidate(nctx->initgr_mc_ctx, + &delete_name); + if (ret != EOK && ret != ENOENT) { + DEBUG(SSSDBG_CRIT_FAILURE, + "Internal failure in memory cache code: %d [%s]\n", + ret, strerror(ret)); + } } done: