From cfaa16fe871f10f5bba0a55beb39e8223dbdf001 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn@redhat.com>
Date: Feb 26 2014 18:29:26 +0000
Subject: KRB5: Fix condition for empty string


Reported by: cppcheck

Finding the same expression on both sides of an operator || is suspicious and
might indicate a cut and paste or logic error.

Resolves:
https://fedorahosted.org/sssd/ticket/2258

Reviewed-by: Michal Žídek <mzidek@redhat.com>

---

diff --git a/src/providers/krb5/krb5_common.c b/src/providers/krb5/krb5_common.c
index 3d0fc0b..bf7b1f0 100644
--- a/src/providers/krb5/krb5_common.c
+++ b/src/providers/krb5/krb5_common.c
@@ -422,7 +422,7 @@ errno_t write_krb5info_file(const char *realm, const char *server,
     mode_t old_umask;
 
     if (realm == NULL || *realm == '\0' || server == NULL || *server == '\0' ||
-        service == NULL || service == '\0') {
+        service == NULL || *service == '\0') {
         DEBUG(SSSDBG_CRIT_FAILURE,
               "Missing or empty realm, server or service.\n");
         return EINVAL;