From c4a3b24dc70fb50c8c0cc5490c29a3755d8b1b73 Mon Sep 17 00:00:00 2001 From: Fabiano Fidêncio Date: Aug 26 2016 13:25:03 +0000 Subject: SECRETS: Return ENOENT when_deleting a non-existent secret For this, just make use of the sysdb_error_to_errno() function. Resolves: https://fedorahosted.org/sssd/ticket/3125 Signed-off-by: Fabiano Fidêncio Reviewed-by: Lukáš Slebodník Reviewed-by: Jakub Hrozek --- diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c index 1746924..ac3049b 100644 --- a/src/responder/secrets/local.c +++ b/src/responder/secrets/local.c @@ -375,15 +375,10 @@ int local_db_delete(TALLOC_CTX *mem_ctx, int ret; ret = local_db_dn(mem_ctx, lctx->ldb, req_path, &dn); - if (ret != EOK) goto done; + if (ret != EOK) return ret; ret = ldb_delete(lctx->ldb, dn); - if (ret != EOK) { - ret = EIO; - } - -done: - return ret; + return sysdb_error_to_errno(ret); } int local_db_create(TALLOC_CTX *mem_ctx,