From be0a90dcb8ef938b4be07d85466284f8cb6126ca Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh@redhat.com>
Date: Feb 22 2011 20:21:47 +0000
Subject: Fix uninitialized value error in ipa_get_id_options()


Previously, we were only constructing the basedn variable if the
ldap_search_base was not specified (which is unlikely to be in use
when using the IPA provier). However, if it did happen,
constrcuction of the compat search base for netgroups would be
using an uninitialized value.

Fixes https://fedorahosted.org/sssd/ticket/806

---

diff --git a/src/providers/ipa/ipa_common.c b/src/providers/ipa/ipa_common.c
index 94e4367..397e418 100644
--- a/src/providers/ipa/ipa_common.c
+++ b/src/providers/ipa/ipa_common.c
@@ -272,14 +272,14 @@ int ipa_get_id_options(struct ipa_options *ipa_opts,
         goto done;
     }
 
-    if (NULL == dp_opt_get_string(ipa_opts->id->basic, SDAP_SEARCH_BASE)) {
-        ret = domain_to_basedn(tmpctx,
-                               dp_opt_get_string(ipa_opts->basic, IPA_DOMAIN),
-                               &basedn);
-        if (ret != EOK) {
-            goto done;
-        }
+    ret = domain_to_basedn(tmpctx,
+                           dp_opt_get_string(ipa_opts->basic, IPA_DOMAIN),
+                           &basedn);
+    if (ret != EOK) {
+        goto done;
+    }
 
+    if (NULL == dp_opt_get_string(ipa_opts->id->basic, SDAP_SEARCH_BASE)) {
         /* FIXME: get values by querying IPA */
         /* set search base */
         value = talloc_asprintf(tmpctx, "cn=accounts,%s", basedn);