From 55fcd37c086f699db1aeac54a3df046b60755ff6 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Feb 29 2012 18:52:08 +0000 Subject: Handle cases where UID is -1 Also removes an unnecessary range check (since it's already handled by strtoint32() https://fedorahosted.org/sssd/ticket/1216 --- diff --git a/src/util/find_uid.c b/src/util/find_uid.c index f4156ce..77b9f22 100644 --- a/src/util/find_uid.c +++ b/src/util/find_uid.c @@ -137,7 +137,7 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid) } else { *e = '\0'; } - num = strtouint32(p, &endptr, 10); + num = (uint32_t) strtoint32(p, &endptr, 10); error = errno; if (error != 0) { DEBUG(1, ("strtol failed [%s].\n", strerror(error))); @@ -148,11 +148,6 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid) return EINVAL; } - if (num >= UINT32_MAX) { - DEBUG(1, ("uid out of range.\n")); - return ERANGE; - } - } else { DEBUG(1, ("format error\n")); return EINVAL;