0a8a06a Refactor krb5 child

1 file Authored by simo 11 years ago, Committed by jhrozek 11 years ago,
    Refactor krb5 child
    
    The aim of this refactoring is to make the code readable and understandable.
    This code has grown organically over time and has becomed confused and
    baroque enough that understanding it's very simple flow had become very
    complex for the uninitiated. Complex flows easily hide nasty bugs.
    
    Improvements:
    - Remove dead/unused data storage
    - Fix and simplify talloc hierarchy, use a memory context (kr) for the
    whole code and allocate kr->pd where it is filled up.
    - Rename some functions to create a better name space (easier for
    searching fucntions across the tree)
    - Streamline setup function, by spliting out fast setup in a subroutine.
    - Avoid confusing indirection in executng actual functions by not
    using the krb5_req child_req member.
    - Make main() flow s now simmetric, send abck data from the main function
    instead of delegating a reply to every inner function that implements a
    command.
    
    Now the flow is evident from the main function:
    1. read request
    2. setup data
    3. execute command
    4. send reply back
    
        
file modified
+210 -288