From 082e13dba488ebb2b948d6a362095153714b669f Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose@redhat.com>
Date: Dec 19 2014 16:45:55 +0000
Subject: libwbclient: initialize some return values


Some callers of libwbclient functions expects the return values are
initialized even it the functions returns an error. This patch adds some
initializations to meet this requirement.

Resolves https://fedorahosted.org/sssd/ticket/2537

Reviewed-by: Pavel Reichl <preichl@redhat.com>

---

diff --git a/src/sss_client/libwbclient/wbc_pam_sssd.c b/src/sss_client/libwbclient/wbc_pam_sssd.c
index 893a5c1..174cf13 100644
--- a/src/sss_client/libwbclient/wbc_pam_sssd.c
+++ b/src/sss_client/libwbclient/wbc_pam_sssd.c
@@ -45,6 +45,10 @@ wbcErr wbcAuthenticateUserEx(const struct wbcAuthUserParams *params,
                  struct wbcAuthUserInfo **info,
                  struct wbcAuthErrorInfo **error)
 {
+    if (error != NULL) {
+        *error = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }
 
@@ -52,6 +56,10 @@ wbcErr wbcAuthenticateUserEx(const struct wbcAuthUserParams *params,
 wbcErr wbcCheckTrustCredentials(const char *domain,
                 struct wbcAuthErrorInfo **error)
 {
+    if (error != NULL) {
+        *error = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }
 
@@ -59,6 +67,10 @@ wbcErr wbcCheckTrustCredentials(const char *domain,
 wbcErr wbcChangeTrustCredentials(const char *domain,
                  struct wbcAuthErrorInfo **error)
 {
+    if (error != NULL) {
+        *error = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }
 
@@ -102,6 +114,14 @@ wbcErr wbcChangeUserPasswordEx(const struct wbcChangePasswordParams *params,
                    enum wbcPasswordChangeRejectReason *reject_reason,
                    struct wbcUserPasswordPolicyInfo **policy)
 {
+    if (error != NULL) {
+        *error = NULL;
+    }
+
+    if (policy != NULL) {
+        *policy = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }
 
@@ -129,6 +149,18 @@ wbcErr wbcLogonUser(const struct wbcLogonUserParams *params,
             struct wbcAuthErrorInfo **error,
             struct wbcUserPasswordPolicyInfo **policy)
 {
+    if (info != NULL) {
+        *info = NULL;
+    }
+
+    if (error != NULL) {
+        *error = NULL;
+    }
+
+    if (policy != NULL) {
+        *policy = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }
 
@@ -137,6 +169,10 @@ wbcErr wbcCredentialCache(struct wbcCredentialCacheParams *params,
                           struct wbcCredentialCacheInfo **info,
                           struct wbcAuthErrorInfo **error)
 {
+    if (error != NULL) {
+        *error = NULL;
+    }
+
     WBC_SSSD_NOT_IMPLEMENTED;
 }