#575 [path_utils] dead storage in path_utils.c
Closed: fixed 2 years ago by atikhonov. Opened 13 years ago by jhrozek.

Two cases of dead storage in path_utils.c:

- in `directory_list()`, the value of `prune` in unconditionally overwritten after the first assignment:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-NCECM2.html#EndPath

- in `is_ancestor_path()`, the value of result is set in all the branches which also return as well as when no branch is selected. Maybe it would be nicer to rewrite the code with if..else if..else..
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-gp1oRt.html#EndPath

- in `split_path()`, although the value stored to `component_len` is used in the enclosing expression, the value is never actually read from `component_len` after that point:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-rpgeQB.html#EndPath

Assigning to dpal as per his request.


Fields changed

priority: major => minor

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

Fields changed

rhbz: => 0

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

Metadata Update from @jhrozek:
- Issue assigned to dpal
- Issue set to the milestone: Tools 2.0

7 years ago

Metadata Update from @atikhonov:
- Custom field component adjusted to None (was: Path Utils)
- Custom field design_review reset (from 0)
- Custom field patch adjusted to on (was: 1)
- Custom field selected adjusted to None
- Custom field testsupdated reset (from 0)
- Custom field type adjusted to None (was: defect)
- Custom field version adjusted to None (was: 1.2.1)
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata