In ini_aug_regex_prepare(), regcomp(7) is called without passing REG_EXTENDED. This results in POSIX Basic regular expressions being used. This is undesirable largely because it is unexpected and unfamiliar to most people who have worked with regular expressions before. Basic REs lack many of the features of the extended set; as per the man page, "'|', '+', and '?' are ordinary characters and there is no equivalent for their functionality.".
ini_aug_regex_prepare()
regcomp(7)
REG_EXTENDED
All that said, I can understand a case for not wanting extended regexes (if I understand correctly, extended supports backreferences while basic does not). However, either way the decision is made, it does need to be specified in the documentation; having to read the implementation to figure this out is a bit much.
Fields changed
rhbz: => todo
Metadata Update from @rharwood: - Issue set to the milestone: ding-libs 0.6.0
master:
Metadata Update from @lslebodn: - Custom field component adjusted to None (was: INI Parser) - Custom field design_review reset (from 0) - Custom field mark reset (from 0) - Custom field patch reset (from 0) - Custom field review reset (from 0) - Custom field selected adjusted to None - Custom field sensitive reset (from 0) - Custom field testsupdated reset (from 0) - Custom field type adjusted to None (was: defect) - Custom field version adjusted to None (was: master) - Issue close_status updated to: fixed - Issue set to the milestone: ding-libs 0.7.0 (was: ding-libs 0.6.0) - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.