#89 FR: Show "Detail tweaks of JS shield for this site" for custom levels
Closed: Fixed 2 years ago by polcak. Opened 2 years ago by gersonzao.

This would allow the user to know which protections are breaking a website or not and to change these protections specifically for a website. Please let me know if there's any reason why it isn't and shouldn't be an option


Steps to reproduce

  1. Create a custom level.
  2. Open a domain like jshelter.org and apply the level (or alternatively configure the same on "JS Shield details" page).
  3. (Re)load the page.
  4. Click on the popup, modify JS Shield,
  5. The detail tweaks button is missing.

Additional info

  1. Open the popup
  2. Modify JSS
  3. When applying a built-in level, the detail tweaks button is visible, it is removed when selecting a custom level.

Version

Confirmed in 0.11.2

Metadata Update from @polcak:
- Issue assigned to polcak
- Issue tagged with: bug

2 years ago

Level 0 should not be allowed to be tweaked. I locally edited the code to show tweaking button on all levels. That allowed me to apply L0 but activate some wrappers in the pop up. However, the tweaks are not stored to the config. After refresh the popup shows JSS slider as off. We would need to change a lot of logic around L0 to let users to tweak that level.

With other levels I did not found any problem as I originally expected.

So I will go with else (current_level.level_id !== "0") and release in 0.11.4

Metadata Update from @polcak:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Log in to comment on this ticket.

Metadata