#81 Network Boundary Shield description on the web does not warn Chromium-based users about implementation flaws: merge all NBS files to generate the description
Opened 7 months ago by polcak. Modified 4 months ago

Summary

https://pagure.io/JShelter/webextension/blob/main/f/chrome/http_shield_chrome.js#_24 describes some crucial details about the Network Boundary Shield in Chromium-based browsers that are not available on https://jshelter.org/nbs/.

Please merge https://pagure.io/JShelter/webextension/blob/main/f/common/http_shield_common.js#_25, https://pagure.io/JShelter/webextension/blob/main/f/chrome/http_shield_chrome.js#_24, https://pagure.io/JShelter/webextension/blob/main/f/firefox/http_shield_firefox.js#_24 to generate https://jshelter.org/nbs/.

Expected result

I think that the page should start with the description as is (common/http_shield_common.js). Below this text we should add a section with a heading of "Specific information for JShelter in Firefox" with the text from firefox/http_shield_firefox.js and a heading of "Specific information for JShelter in Chromium-based browsers" with the text from chrome/http_shield_chrome.js.


Metadata Update from @polcak:
- Issue assigned to rlafuente

7 months ago

Right now, pages are generated from the comments in code in a one-to-one correspondence, and our site generator doesn't support "including" comment blocks from arbitrary files.

We can look into this but it's definitely not trivial to implement -- would this be a useful feature for other use cases, or is it only here?

As a current compromise, we'd suggest manually including the content inside the content/pages/nbs.md file. I can take care of this if you're okay with this workaround.

I guess that for now it is only the HTTP Shield. Can we add links similar to JSS wrappers?

Login to comment on this ticket.

Metadata