Current implementation of window.name wrapper removes the content with every page load. Some applications like https://nahlizenidokn.cuzk.cz needs the property to work correctly (show maps on this page). We need to remove the content only when eTLD+1 changes.
window.name
To get eTLD+1 dtabase, we will probably need https://github.com/gorhill/publicsuffixlist.js (see the link for the docs). It seems that we will need https://github.com/mathiasbynens/punycode.js as a dependency, too.
Once fixed, we should reenable windowname group for level 2.
Once we have the database integrated, we should update farbling hash to depend on this database.
Metadata Update from @polcak: - Issue marked as depending on: #46
Since you already depend on NSCL, you may want to just use tld.getDomain().
I've just modified include.sh to automatically update the suffix list everytime /nscl/common/tld.js gets included, therefore you shouldn't need to modify anything in your build workflow (just add the inclusion in manifest.json).
I'm currently looking into the other issues where you called for information from me. Thank you for your patience :)
I am not going to disable the wrapper for Chrome users in 0.10. There is some activity in #46 and it seems to me that we will have a proper fix soon. We have the broken wrapper active for about a year or even more, so I do not see much harm in having the wrapper active for a week or two. There is no need to create the confusion in the user-defined levels if we disabled the protection now and activated it a few days later.
A reminder for myself: We will need to activate the wrapper if (etld+1(previousUrl) !== etld+1(nextUrl)) && (winownameactive(jsslevel(previousUrl)) || winownameactive(jsslevel(previousUrl)))
(etld+1(previousUrl) !== etld+1(nextUrl)) && (winownameactive(jsslevel(previousUrl)) || winownameactive(jsslevel(previousUrl)))
Here's my patch.
Released in 0.11
Metadata Update from @polcak: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.