JS-Shield / JS-Shield

Clone

#1 unit_test code needs clarifications
Closed 3 years ago by polcak. Opened 3 years ago by polcak.

Closed
Reopen Issue
  • It is not clear to which code the MIT.LICENSE applies as for example the tests in the test/ directory are GPLv3
  • It is not clear how to run the tests
  • moc_objects/sinon-chrome-webextensions.min.js - unknown code without licence, why do we need the minified version? It might be worth to consider if the approach of embedding the code of the library makes sense.
  • lib/jasmine-3.5.0 - it might be worth to consider if the approach of embedding the code of the library makes sense.

As far as I am concerned, this was solved by https://pagure.io/JS-Shield/JS-Shield/c/63b660fc494e6756166cb093c8fbfe5e3b18cfcb?branch=master.

  • We transformed unit tests into node-based tests which means we no longer fork dependencies (sinon chrome, jasmin),
  • MIT.LICENSE was deleted as it applied to Jasmin which is no longer forked in the repository,
  • README for tests seems to be understandable by several developers.

I am closing the issue, please reopen if you disagree.

Metadata Update from @polcak:
- Issue status updated to: Closed (was: Open)
3 years ago

Login to comment on this ticket.

Metadata
None
None
None
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.