PR#20: Add short arg for --no-dynamic-buildrequires and remove unnecessary source numbering - GoSIG/go2rpm

GoSIG / go2rpm

#20 Add short arg for --no-dynamic-buildrequires and remove unnecessary source numbering

Merged 2 years ago by gotmax23. Opened 2 years ago by gotmax23.

GoSIG/ gotmax23/go2rpm master into master

Remove unnecessary source numbering

Maxwell G • 2 years ago

f1768f7

Add short arg for --no-dynamic-buildrequires

Maxwell G • 2 years ago

450bd51

go2rpm/__main__.py

file modified

+1 -1

		`@@ -545,7 +545,7 @@`
		`)`
		`parser.add_argument("--dynamic-buildrequires", action="store_true",`
		`help="Use dynamic BuildRequires feature")`
		`- parser.add_argument("--no-dynamic-buildrequires", action="store_true",`
		`+ parser.add_argument("-R", "--no-dynamic-buildrequires", action="store_true",`
		`help="Do not use dynamic BuildRequires feature")`
		`parser.add_argument(`
		`"-C",`

go2rpm/templates/profile2.spec

file modified

+1 -1

		`@@ -54,7 +54,7 @@`
		`{% if license_comments is not none %}{{ license_comments }}`
		`{% endif %}`
		`URL: %{gourl}`
		`- Source0: %{gosource}`
		`+ Source: %{gosource}`

		`{% if not generate_buildrequires %}`
		`{% if buildrequires\|length > 0 %}`

gotmax23 commented 2 years ago

See the respective commit messages for more information.

mikelo2 commented 2 years ago

just curious, why -R? -S for "static" would make more sense for me, but as there might be another reason I would like to learn about it.

eclipseo commented 2 years ago

No issue for me. You can bikeshed about which letter is your favorite.
@gotmax23 I'll let you merge and rebuild if this is urgent for you.

gotmax23 commented 2 years ago

just curious, why -R? -S for "static" would make more sense for me, but as there might be another reason I would like to learn about it.

It's supposed to stand for requires, but -r was already taken. I suppose we should also add a short arg for --dynamic-buildrequires, but it's already the default, so :shrug:.

gotmax23 commented 2 years ago

I will merge this later today so speak now or forever hold your peace if you have any objections.

Pull-Request has been merged by gotmax23

2 years ago