According to @tibbs :
I'm curious as to why there is an extra separator in the name. From https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple: If the base package name does not end with a digit, the version MUST be directly appended to the package name with no intervening separator. So unless I'm missing something, the package should be named golang-k8s-klog2
https://pagure.io/releng/fedora-scm-requests/issue/55886#comment-871881
Impact:
./golang-bug-serial-1 ./golang-github-acme-lego-3 ./golang-github-ahmetb-linq-3 ./golang-github-alecaivazis-survey-2 ./golang-github-alecthomas-chroma-2 ./golang-github-alecthomas-kong-hcl-2 ./golang-github-apache-beam-2 ./golang-github-apparentlymart-textseg-12 ./golang-github-apparentlymart-textseg-13 ./golang-github-aws-sdk-2 ./golang-github-bmatcuk-doublestar-3 ./golang-github-bmatcuk-doublestar-4 ./golang-github-caddyserver-caddy-1 ./golang-github-casbin-2 ./golang-github-cheggaaa-pb-3 ./golang-github-colinmarc-hdfs-2 ./golang-github-d5-tengo-2 ./golang-github-distribution-3 ./golang-github-doug-martin-goqu-8 ./golang-github-elastic-elasticsearch-6 ./golang-github-gdamore-tcell-2 ./golang-github-git-5 ./golang-github-git-billy-5 ./golang-github-git-fixtures-4 ./golang-github-git-lfs-gitobj-2 ./golang-github-git-lfs-wildmatch-2 ./golang-github-gocolly-colly-2 ./golang-github-golangci-lint-1 ./golang-github-google-renameio-2 ./golang-github-gorp-3 ./golang-github-grpc-ecosystem-gateway-2 ./golang-github-hashicorp-hcl-2 ./golang-github-iguanesolutions-systemd-5 ./golang-github-ipfs-log-2 ./golang-github-jackc-chunkreader-2 ./golang-github-jackc-pgx-3 ./golang-github-jcmturner-aescts-2 ./golang-github-jcmturner-dnsutils-2 ./golang-github-jcmturner-goidentity-6 ./golang-github-jcmturner-gokrb5-8 ./golang-github-jcmturner-rpc-2 ./golang-github-jeffail-gabs-2 ./golang-github-jwt-4 ./golang-github-labstack-echo-4 ./golang-github-marten-seemann-qtls-go1-15 ./golang-github-marten-seemann-qtls-go1-16 ./golang-github-marten-seemann-qtls-go1-17 ./golang-github-marten-seemann-qtls-go1-18 ./golang-github-marten-seemann-qtls-go1-19 ./golang-github-maruel-panicparse-2 ./golang-github-masterminds-semver-1 ./golang-github-minio-6 ./golang-github-mitchellh-hashstructure-2 ./golang-github-moby-swarmkit-2 ./golang-github-nathanaelle-syslog5424-2 ./golang-github-ncw-swift-2 ./golang-github-nicksnyder-i18n-2 ./golang-github-onsi-ginkgo-2 ./golang-github-oracle-oci-sdk-24 ./golang-github-pelletier-toml-2 ./golang-github-peterbourgon-ff-3 ./golang-github-playground-assert-2 ./golang-github-playground-validator-10 ./golang-github-posener-complete-2 ./golang-github-qingstor-sdk-4 ./golang-github-quay-clair-3 ./golang-github-quay-clair-4 ./golang-github-redis-7 ./golang-github-redis-8 ./golang-github-schollz-cli-2 ./golang-github-schollz-pake-3 ./golang-github-schollz-progressbar-2 ./golang-github-schollz-progressbar-3 ./golang-github-spiffe-2 ./golang-github-stomp-3 ./golang-github-twpayne-vfs-4 ./golang-github-urfave-cli-2 ./golang-github-vbauerster-mpb-5 ./golang-github-vektah-gqlparser-2 ./golang-github-vmihailenco-msgpack-4 ./golang-github-vultr-govultr-2 ./golang-github-zmap-zlint-2 ./golang-github-zmap-zlint-3 ./golang-gonum-1 ./golang-gopkg-alecthomas-kingpin-2 ./golang-gopkg-alexcesaro-quotedprintable-3 ./golang-gopkg-aphistic-golf-0 ./golang-gopkg-asn1-ber-1 ./golang-gopkg-bufio-1 ./golang-gopkg-check-1 ./golang-gopkg-cheggaaa-pb-1 ./golang-gopkg-data-dog-sqlmock-1 ./golang-gopkg-eapache-channels-1 ./golang-gopkg-errgo-2 ./golang-gopkg-fatih-pool-2 ./golang-gopkg-fsnotify-0 ./golang-gopkg-gcfg-1 ./golang-gopkg-gorethink-3 ./golang-gopkg-gorp-1 ./golang-gopkg-h2non-gock-1 ./golang-gopkg-inf-0 ./golang-gopkg-ini-1 ./golang-gopkg-jcmturner-aescts-1 ./golang-gopkg-jcmturner-dnsutils-1 ./golang-gopkg-jcmturner-goidentity-2 ./golang-gopkg-jcmturner-goidentity-3 ./golang-gopkg-jcmturner-gokrb5-5 ./golang-gopkg-jcmturner-gokrb5-7 ./golang-gopkg-jcmturner-rpc-0 ./golang-gopkg-jcmturner-rpc-1 ./golang-gopkg-ldap-2 ./golang-gopkg-ldap-3 ./golang-gopkg-logex-1 ./golang-gopkg-macaron-1 ./golang-gopkg-macaroon-1 ./golang-gopkg-mail-2 ./golang-gopkg-mcuadros-syslog-2 ./golang-gopkg-mgo-2 ./golang-gopkg-natefinch-lumberjack-2 ./golang-gopkg-neurosnap-sentences-1 ./golang-gopkg-ns1-2 ./golang-gopkg-olivere-elastic-2 ./golang-gopkg-olivere-elastic-5 ./golang-gopkg-op-logging-1 ./golang-gopkg-pipe-2 ./golang-gopkg-playground-assert-1 ./golang-gopkg-playground-validator-10 ./golang-gopkg-playground-validator-8 ./golang-gopkg-readline-1 ./golang-gopkg-redis-2 ./golang-gopkg-redis-5 ./golang-gopkg-redis-6 ./golang-gopkg-resty-1 ./golang-gopkg-rethinkdb-6 ./golang-gopkg-retry-1 ./golang-gopkg-robfig-cron-2 ./golang-gopkg-robfig-cron-3 ./golang-gopkg-russross-blackfriday-1 ./golang-gopkg-russross-blackfriday-2 ./golang-gopkg-seborama-govcr-2 ./golang-gopkg-sourcemap-1 ./golang-gopkg-square-jose-2 ./golang-gopkg-src-d-billy-4 ./golang-gopkg-src-d-git-4 ./golang-gopkg-src-d-git-fixtures-3 ./golang-gopkg-stack-0 ./golang-gopkg-tomb-1 ./golang-gopkg-tomb-2 ./golang-gopkg-tylerb-graceful-1 ./golang-gopkg-tylerb-is-1 ./golang-gopkg-validator-2 ./golang-gopkg-vmihailenco-msgpack-2 ./golang-gopkg-warnings-0 ./golang-gopkg-yaml-1 ./golang-gopkg-yaml-2 ./golang-gopkg-yaml-3 ./golang-helm-3 ./golang-mvdan-sh-3 ./golang-nanomsg-mangos-3 ./golang-github-twpayne-xdg-6 ./golang-github-alecthomas-assert-2 ./golang-github-quic-qtls-go1-20 ./golang-oras-1 ./golang-oras-2 ./golang-github-containerd-btrfs-2 ./golang-github-vultr-govultr-3 ./golang-github-hashicorp-lru-2 ./golang-github-pin-tftp-3 ./golang-github-hanwen-fuse-2 ./golang-github-vmihailenco-msgpack-5 ./golang-github-vmihailenco-tagparser-2 ./golang-github-distribution-distribution-3 ./golang-github-exoscale-egoscale-2 ./golang-github-jose-3 ./golang-github-lestrrat-backoff-2 ./golang-gopkg-seborama-govcr-4 ./golang-github-jwt-5 ./golang-github-sebdah-goldie-1 ./golang-github-jedib0t-pretty-6 ./golang-github-gofiber-fiber-2 ./golang-github-apapsch-jsonmerge-2 ./golang-modernc-gc-2 ./golang-github-containerd-cgroups-3 ./golang-github-nats-io-jwt-2
Remedial:
go-rpm-macros: https://pagure.io/go-rpm-macros/pull-request/55
go2rpm: https://pagure.io/GoSIG/go2rpm/pull-request/30
New renamed packages https://copr.fedorainfracloud.org/coprs/eclipseo/macros-fix/builds/
https://pagure.io/packaging-committee/issue/1307
Following the answer from the committee.
What I propose:
As such: - in go-rpm-macro, I make a list of 130-ish goipath exception list. If it is not in the list, the goname is computed according to official guidelines. - in go2rpm, same thing, and instead of putting %goname in Name: field, we put the computed value.
Here are the merge requests:
Testing is done here: https://copr.fedorainfracloud.org/coprs/eclipseo/macros-fix3/builds/
So no exception list harcoded but a flag to gometa instead.
Final draft:
For stability reason we do not touch existing packages.
go-rpm-macros: https://pagure.io/go-rpm-macros/pull-request/56
@eclipseo Everything has been merged. Should we close this issue or is there anything left to discuss?
I opened a PR to clean the go2rpm template:
I think we can close this now. Thanks everyone!
Metadata Update from @gotmax23: - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.