FedoraReview

Clone
Source Code
GIT

#460 Ensure all built binary rpms get installed
Merged a year ago by ngompa. Opened 2 years ago by fed500.
fed500/FedoraReview install-fix  into  master

file modified
+2 -2 
@@ -286,8 +286,8 @@ 
 

                  )
 

              return
 

          _mock_root_setup("While installing built packages", force=True)
 

-         rpms = Mock.get_package_rpm_paths(self.spec)
 

-         rpms.extend(Mock.get_package_debuginfo_paths(self.spec.get_package_nvr()))
 

+         rpms = glob.glob(os.path.join(Mock.resultdir, "*.rpm"))
 

+         rpms = [rpm for rpm in set(rpms) if 'src.rpm' not in rpm]
 

          self.log.info("Installing built package(s)")
 

          output = Mock.install(rpms)
 

          if not output:

Rather than use spec file to get list of binary rpms that will be built,
get the actual binary rpms that are built and install all of them.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2132574

Can you please rebase the PR?
The fc-query change was already merged in another PR.

rebased onto 3969b9ea6404dcf7765b97c95ff61e9c78999a0f
a year ago

Please drop your changes to the spec file.

2 new commits added

  • Install all built rpms not just rpms listed in spec file
  • Replace ttname with fc-query
a year ago

Done. Thanks.

Please drop your fc-query commit entirely

rebased onto 81708a1bbd4f6191fe7c0b7a7abb3ed0c70defcc
a year ago

rebased onto 05aa960
a year ago

Pull-Request has been merged by ngompa
a year ago
Metadata
None
No Tags
Changes Summary 1
+2 -2
file changed
plugins/generic_build.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.