#412 Remove CheckInfoInstall.
Merged 3 years ago by ngompa. Opened 3 years ago by noon.
noon/FedoraReview remove-info-install  into  master

file modified
-32
@@ -1911,38 +1911,6 @@ 

          self.set_passed(self.FAIL if failed else self.PENDING, text)

  

  

- class CheckInfoInstall(GenericCheckBase):

-     """ Check that info files are properly installed. """

- 

-     def __init__(self, base):

-         GenericCheckBase.__init__(self, base)

-         self.url = (

-             "https://docs.fedoraproject.org/en-US"

-             "/packaging-guidelines/Scriptlets/#_texinfo"

-         )

-         self.text = (

-             "Texinfo files are installed using install-info"

-             " in %post and %preun if package has .info files."

-         )

-         self.automatic = True

-         self.type = "MUST"

- 

-     def run(self):

-         using = []

-         failed = False

-         for pkg in self.spec.packages:

-             if self.rpms.find("/usr/share/info/*", pkg):

-                 using.append(pkg)

-                 rpm_pkg = self.rpms.get(pkg)

-                 if not in_list("install-info", [rpm_pkg.post, rpm_pkg.preun]):

-                     failed = True

-         if not using:

-             self.set_passed(self.NA)

-             return

-         text = "Texinfo .info file(s) in " + ", ".join(using)

-         self.set_passed(self.FAIL if failed else self.PENDING, text)

- 

- 

  class CheckGdkPixbufLoaders(GenericCheckBase):

      """ Check that gdk-pixbuf-query-loaders is run if required. """

  

file modified
-2
@@ -312,7 +312,6 @@ 

              ("fail", "CheckGtkQueryModules"),

              ("fail", "CheckGioQueryModules"),

              ("fail", "CheckUpdateIconCache"),

-             ("fail", "CheckInfoInstall"),

              ("fail", "CheckGlibCompileSchemas"),

              ("fail", "CheckUpdateMimeDatabase"),

              ("pending", "CheckBundledFonts"),
@@ -333,7 +332,6 @@ 

              ("pending", "CheckGtkQueryModules"),

              ("pending", "CheckGioQueryModules"),

              ("pending", "CheckUpdateIconCache"),

-             ("pending", "CheckInfoInstall"),

              ("pending", "CheckGlibCompileSchemas"),

              ("pending", "CheckUpdateMimeDatabase"),

              ("pending", "CheckBundledFonts"),

Info files are now implicitly handled because of their pathname. It
is now unnecessary to place explicit %post or %preun scriptlets
anymore.

Pull-Request has been merged by ngompa

3 years ago