| |
@@ -108,10 +108,8 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/#bundling"
|
| |
- )
|
| |
- self.text = "Package contains no bundled libraries without" " FPC exception."
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling"
|
| |
+ self.text = "Package contains no bundled libraries without FPC exception."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -145,7 +143,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_compiler_flags"
|
| |
)
|
| |
- self.text = "%build honors applicable compiler flags or " "justifies otherwise."
|
| |
+ self.text = "%build honors applicable compiler flags or justifies otherwise."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
self.needs.append("generic-large-data") # Ensure unpacked rpms
|
| |
@@ -164,7 +162,7 @@
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/#changelogs"
|
| |
+ "https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs"
|
| |
)
|
| |
self.text = "Changelog in prescribed format."
|
| |
self.automatic = False
|
| |
@@ -181,7 +179,7 @@
|
| |
"/packaging-guidelines/what-can-be-packaged"
|
| |
"/#_impermissible_content"
|
| |
)
|
| |
- self.text = "Sources contain only permissible" " code or content."
|
| |
+ self.text = "Sources contain only permissible code or content."
|
| |
self.automatic = False
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -195,7 +193,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_configuration_files"
|
| |
)
|
| |
- self.text = "%config files are marked noreplace or the reason" " is justified."
|
| |
+ self.text = "%config files are marked noreplace or the reason is justified."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -339,7 +337,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_source_rpm_buildtime_macros"
|
| |
)
|
| |
- self.text = "Macros in Summary, %description expandable at" " SRPM build time."
|
| |
+ self.text = "Macros in Summary, %description expandable at SRPM build time."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -370,7 +368,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_desktop_files"
|
| |
)
|
| |
- self.text = "Package contains desktop file if it is a GUI" " application."
|
| |
+ self.text = "Package contains desktop file if it is a GUI application."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -430,9 +428,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/DistTag/"
|
| |
- )
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/"
|
| |
self.text = "Dist tag is present."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
@@ -619,9 +615,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_documentation"
|
| |
)
|
| |
- self.text = (
|
| |
- "Large documentation files are in a -doc" " subpackage, if required."
|
| |
- )
|
| |
+ self.text = "Large documentation files are in a -doc subpackage, if required."
|
| |
self.automatic = False
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -642,9 +636,7 @@
|
| |
"/packaging-guidelines/LicensingGuidelines/"
|
| |
"#_valid_license_short_names"
|
| |
)
|
| |
- self.text = (
|
| |
- "License field in the package spec file" " matches the actual license."
|
| |
- )
|
| |
+ self.text = "License field in the package spec file matches the actual license."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -836,7 +828,7 @@
|
| |
"/#subpackage-licensing"
|
| |
)
|
| |
self.text = (
|
| |
- "License file installed when any subpackage" " combination is installed."
|
| |
+ "License file installed when any subpackage combination is installed."
|
| |
)
|
| |
self.automatic = False
|
| |
self.type = "MUST"
|
| |
@@ -872,9 +864,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/#_macros"
|
| |
- )
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros"
|
| |
self.text = (
|
| |
"Package consistently uses macros"
|
| |
" (instead of hard-coded directory names)."
|
| |
@@ -888,9 +878,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/#_macros"
|
| |
- )
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros"
|
| |
self.text = "Package uses either %{buildroot} or $RPM_BUILD_ROOT"
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
@@ -961,16 +949,14 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/Naming/"
|
| |
- )
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/"
|
| |
self.text = "Package is named using only allowed ASCII characters."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
def run_on_applicable(self):
|
| |
allowed_chars = (
|
| |
- "abcdefghijklmnopqrstuvwxyz" "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._+"
|
| |
+ "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._+"
|
| |
)
|
| |
output = ""
|
| |
passed = True
|
| |
@@ -994,10 +980,8 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/Naming/"
|
| |
- )
|
| |
- self.text = "Package is named according to the Package Naming" " Guidelines."
|
| |
+ self.url = "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/"
|
| |
+ self.text = "Package is named according to the Package Naming Guidelines."
|
| |
self.automatic = False
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -1046,7 +1030,7 @@
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/#_conflicts"
|
| |
+ "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_conflicts"
|
| |
)
|
| |
self.text = "Package does not generate any conflict."
|
| |
self.automatic = True
|
| |
@@ -1055,7 +1039,7 @@
|
| |
def run(self):
|
| |
text = None
|
| |
if self.spec.expand_tag("Conflicts"):
|
| |
- text = "Package contains Conflicts: tag(s)" " needing fix or justification."
|
| |
+ text = "Package contains Conflicts: tag(s) needing fix or justification."
|
| |
self.set_passed(self.PENDING, text)
|
| |
|
| |
|
| |
@@ -1195,9 +1179,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_file_and_directory_ownership"
|
| |
)
|
| |
- self.text = (
|
| |
- "Package does not own files or directories" " owned by other packages."
|
| |
- )
|
| |
+ self.text = "Package does not own files or directories owned by other packages."
|
| |
self.automatic = True
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -1293,7 +1275,7 @@
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
self.url = (
|
| |
- "https://docs.fedoraproject.org/en-US" "/packaging-guidelines/SourceURL/"
|
| |
+ "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/"
|
| |
)
|
| |
self.text = (
|
| |
"Sources used to build the package match the"
|
| |
@@ -1357,7 +1339,7 @@
|
| |
self.log.debug("No testable sources")
|
| |
self.set_passed(
|
| |
self.PENDING,
|
| |
- "Package has no sources or they" " are generated by developer",
|
| |
+ "Package has no sources or they are generated by developer",
|
| |
)
|
| |
return
|
| |
msg = "Check did not complete"
|
| |
@@ -1543,7 +1525,7 @@
|
| |
"https://docs.fedoraproject.org/en-US"
|
| |
"/packaging-guidelines/#_debuginfo_packages"
|
| |
)
|
| |
- self.text = "Useful -debuginfo package or justification" " otherwise."
|
| |
+ self.text = "Useful -debuginfo package or justification otherwise."
|
| |
self.automatic = False
|
| |
self.type = "MUST"
|
| |
|
| |
@@ -1646,7 +1628,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = "https://fedoraproject.org/wiki/EPEL" ":Packaging#Icon_Cache"
|
| |
+ self.url = "https://fedoraproject.org/wiki/EPEL:Packaging#Icon_Cache"
|
| |
self.text = (
|
| |
"gtk-update-icon-cache is invoked in %postun"
|
| |
" and %posttrans if package contains icons."
|
| |
@@ -1691,7 +1673,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = "https://fedoraproject.org/wiki/EPEL" ":Packaging#desktop-database"
|
| |
+ self.url = "https://fedoraproject.org/wiki/EPEL:Packaging#desktop-database"
|
| |
self.text = (
|
| |
"update-desktop-database is invoked in %post and"
|
| |
" %postun if package contains desktop file(s)"
|
| |
@@ -1811,7 +1793,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = "https://fedoraproject.org/wiki/EPEL" ":Packaging#GTK.2B_modules"
|
| |
+ self.url = "https://fedoraproject.org/wiki/EPEL:Packaging#GTK.2B_modules"
|
| |
self.text = "gtk-query-immodules is invoked when required"
|
| |
|
| |
self.automatic = True
|
| |
@@ -1849,7 +1831,7 @@
|
| |
"Packaging:Scriptlets&oldid=494555#GTK.2B_modules"
|
| |
)
|
| |
self.text = (
|
| |
- "gtk-query-immodules must not be invoked for" " Fedora 24 and later."
|
| |
+ "gtk-query-immodules must not be invoked for Fedora 24 and later."
|
| |
)
|
| |
self.set_passed(self.FAIL if failed else self.NA, text)
|
| |
|
| |
@@ -1859,7 +1841,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = "https://fedoraproject.org/wiki/EPEL" ":Packaging#GSettings_Schema"
|
| |
+ self.url = "https://fedoraproject.org/wiki/EPEL:Packaging#GSettings_Schema"
|
| |
self.text = (
|
| |
"glib-compile-schemas is run in %postun and"
|
| |
" %posttrans if package has *.gschema.xml files. "
|
| |
@@ -1970,7 +1952,7 @@
|
| |
|
| |
def __init__(self, base):
|
| |
GenericCheckBase.__init__(self, base)
|
| |
- self.url = "https://fedoraproject.org/wiki/EPEL" ":Packaging#gdk-pixbuf_loaders"
|
| |
+ self.url = "https://fedoraproject.org/wiki/EPEL:Packaging#gdk-pixbuf_loaders"
|
| |
self.text = (
|
| |
"gdk-pixbuf-query-loaders is invoked in %post and"
|
| |
" %postun to update gdk-pixbuf"
|
| |
@@ -2164,7 +2146,7 @@
|
| |
provides = deps.list_provides(pkg)
|
| |
if any("deprecated()" in p for p in provides):
|
| |
self.set_passed(
|
| |
- self.FAIL, pkg + " is deprecated, you must " "not depend on it."
|
| |
+ self.FAIL, pkg + " is deprecated, you must not depend on it."
|
| |
)
|
| |
return
|
| |
|
| |