PR#332: Fix detection of pkg suffixes to ignore - FedoraReview

FedoraReview

#332 Fix detection of pkg suffixes to ignore

Merged 5 years ago by ngompa. Opened 5 years ago by eclipseo.

Unknown source fix_pkg_end_detection_in_CheckFullVerReqSub into devel

Fix detection of pkg suffixes to ignore

Robert-André Mauchin • 5 years ago

ee9bfb0

plugins/generic_should.py

file modified

+1 -1

		`@@ -264,7 +264,7 @@`
		`for pkg in self.spec.packages:`
		`if pkg == self.spec.base_package:`
		`continue`
		`- for pkg_end in ['debuginfo', 'debugsource', '-javadoc', '-doc']:`
		`+ if pkg.endswith(('debuginfo', 'debugsource', '-javadoc', '-doc')):`
		`continue`
		`reqs = ''.join(self.rpms.get(pkg).format_requires)`
		`if regex not in reqs:`

eclipseo commented 5 years ago

The current code does not work as expected. It should be a if
construction and not a for loop. The previous patch I had made for it is
likely to have been badly commited.

eclipseo commented 5 years ago

@ngompa Trivial fix for CheckFullVerReqSub. The current code is a mishap from a previous patch.

rebased onto ee45b1f6acf6e2bd7cc8efcc1a22e6d89b109ee9

5 years ago

rebased onto ee9bfb0

5 years ago