https://fedorahosted.org/FedoraReview/

  source, issue tracker, etc.

  .TP

  Rules for Fedora packages.

      def __init__(self, base):

          """ Instanciate check variable """

          RCheckBase.__init__(self, base)

          self.text = 'Package contains the mandatory BuildRequires.'

          self.automatic = True

      def __init__(self, base):

          """ Instanciate check variable """

          RCheckBase.__init__(self, base)

          self.text = 'Package requires R-core.'

          self.automatic = True

      def __init__(self, base):

          """ Instanciate check variable """

          RCheckBase.__init__(self, base)

          self.automatic = True

          self.text = 'Package have the default element marked as %%doc :'

      def __init__(self, base):

          """ Instanciate check variable """

          RCheckBase.__init__(self, base)

          self.text = 'Latest version is packaged.'

          self.automatic = True

          self.type = 'SHOULD'

      def __init__(self, base):

          """ Instantiate check variable """

          RCheckBase.__init__(self, base)

          self.text = 'The %check macro is present'

          self.automatic = True

          self.type = 'SHOULD'

      def __init__(self, base):

          """ Instanciate check variable """

          RCheckBase.__init__(self, base)

          self.text = 'The package has the standard %install section.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'ldconfig called in %post and %postun if required.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Header files in -devel subpackage, if present.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Package contains no static executables.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Development (unversioned) .so files ' \

                      'in -devel subpackage, if present.'

          self.automatic = True

      '''

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Package does not contain any libtool archives (.la)'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Rpath absent or only used for internal libs.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Provides: bundled(gnulib) in place as required.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'Package does not contain kernel modules.'

          self.automatic = False

          self.type = 'MUST'

      """ Check that gcc/gcc-c++/clang is present """

      def __init__(self, base):

          CCppCheckBase.__init__(self, base)

          self.text = 'If your application is a C or C++ application you must ' \

                      'list a BuildRequires against gcc, gcc-c++ or clang.'

          self.automatic = True

      """ Base class for all fonts specific checks. """

      def __init__(self, base):

          CheckBase.__init__(self, base, __file__)

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package is licensed with an open-source'       \

                      ' compatible license and meets other legal'     \

                      ' requirements as defined in the legal section' \

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package contains no bundled libraries without' \

                      ' FPC exception.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = '%build honors applicable compiler flags or ' \

                      'justifies otherwise.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Changelog in prescribed format.'

          self.automatic = False

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Sources contain only permissible' \

                      ' code or content.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = '%config files are marked noreplace or the reason' \

                      ' is justified.'

          self.automatic = True

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package uses hardened build flags if required to.'

          self.automatic = True

          self.needs.append('generic-large-data')      # Ensure unpacked rpms

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Each %files section contains %defattr if rpm < 4.4'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Macros in Summary, %description expandable at' \

                      ' SRPM build time.'

          self.automatic = True

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package contains desktop file if it is a GUI' \

                      ' application.'

          self.automatic = True

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package installs a  %{name}.desktop using' \

                      ' desktop-file-install or desktop-file-validate' \

                      ' if there is such a file.'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Development files must be in a -devel package'

          self.automatic = False

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Dist tag is present.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package requires other packages for directories it uses.'

          self.automatic = True

          self.type = 'MUST'

      MUST: If a package includes something as %doc, it must not affect

      the runtime of the application.  To summarize: If it is in %doc,

      the program must run properly if it is not present.

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package uses nothing in %doc for runtime.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package is not known to require ExcludeArch.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package does not contain duplicates in %files.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Permissions on files are set properly.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package complies to the Packaging Guidelines'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Large documentation files are in a -doc' \

                      ' subpackage, if required.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'License field in the package spec file' \

                      ' matches the actual license.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          if not (self.flags['EPEL5'] or self.flags['EPEL6']):

              self._license_flag = 'L'

              self._license_macro = '%license'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'License file installed when any subpackage' \

                      ' combination is installed.'

          self.automatic = False

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'The spec file handles locales properly.'

          self.automatic = False

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package consistently uses macros' \

                      ' (instead of hard-coded directory names).'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package uses either  %{buildroot} or $RPM_BUILD_ROOT'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = "Package use %makeinstall only when make install" \

                      " DESTDIR=... doesn't work."

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'If the package is under multiple licenses, the licensing'\

                      ' breakdown must be documented in the spec.'

          self.automatic = False

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package is named using only allowed ASCII characters.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package is named according to the Package Naming' \

                      ' Guidelines.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'No %config files under /usr.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package does not generate any conflict.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package obeys FHS, except libexecdir and /usr/target.'

          self.automatic = False

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'If the package is a rename of another package, proper' \

                      ' Obsoletes and Provides are present.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package must own all directories that it creates.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package does not own files or directories' \

                      ' owned by other packages.'

          self.automatic = True

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package is not relocatable.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

                     'EPEL/GuidelinesAndPolicies#EL5'

          self.text = 'EPEL5: Package requires pkgconfig, if .pc files' \

                      ' are present.'

  class CheckRequires(GenericCheckBase):

      '''

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Requires correct, justified where necessary.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Sources used to build the package match the' \

                      ' upstream source, as provided in the spec URL.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Spec file is legible and written in American English.'

          self.automatic = False

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Spec file name must match the spec package' \

                      ' %{name}, in the format %{name}.spec.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Static libraries in -static or -devel subpackage, ' \

                       'providing  -devel if present.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package contains  systemd file(s) if in need.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'File names are valid UTF-8.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Useful -debuginfo package or justification' \

                      ' otherwise.'

          self.automatic = False

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package does not use a name that already exists.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Only use %_sourcedir in very specific situations.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'gio-querymodules is invoked in %postun and %post' \

                      ' if package has /lib/gio/modules/* files'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'GConf schemas are properly installed'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Texinfo files are installed using install-info' \

                      ' in %post and %preun if package has .info files.'

          self.automatic = True

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'systemd_post is invoked in %post, systemd_preun in' \

                      ' %preun, and systemd_postun in %postun for Systemd' \

                      ' service files.'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'systemd_user_post is invoked in %post and' \

                      ' systemd_user_preun in %preun for Systemd' \

                      ' user units service files.'

      def __init__(self, base):

          GenericCheckBase.__init__(self, base)

          self.text = 'Package must not depend on deprecated() packages.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          BuildCheckBase.__init__(self, base)

          self.text = 'Package successfully compiles and builds into' \

                      ' binary rpms on at least one supported primary' \

                      ' architecture.'

      '''

      def __init__(self, base):

          BuildCheckBase.__init__(self, base)

          self.text = 'Rpmlint is run on all rpms the build produces.'

          self.automatic = True

          self.type = 'MUST'

      def __init__(self, base):

          BuildCheckBase.__init__(self, base)

          self.text = 'Package installs properly.'

          self.automatic = True

          self.type = 'MUST'

      '''

      def __init__(self, base):

          BuildCheckBase.__init__(self, base)

          self.text = 'Rpmlint is run on all installed packages.'

          self.automatic = True

          self.type = 'EXTRA'

      '''

      def __init__(self, base):

          BuildCheckBase.__init__(self, base)

          self.text = 'Rpmlint is run on debuginfo package(s).'

          self.automatic = True

          self.type = 'EXTRA'

  class CheckBuildInMock(GenericShouldCheckBase):

      '''

      SHOULD: The reviewer should test that the package builds in mock.

      '''

      def __init__(self, base):

          GenericShouldCheckBase.__init__(self, base)

                     'PackageMaintainers/MockTricks'

          self.text = 'Reviewer should test that the package builds in mock.'

          self.automatic = True

      def __init__(self, base):

          GenericShouldCheckBase.__init__(self, base)

          self.text = 'Buildroot is not present'

          self.automatic = True

          self.type = 'SHOULD'

      def __init__(self, base):

          GenericShouldCheckBase.__init__(self, base)

          self.text = 'Package has no %clean section with rm -rf' \

                      ' %{buildroot} (or $RPM_BUILD_ROOT)'

          self.automatic = True

      def __init__(self, base):

          GenericShouldCheckBase.__init__(self, base)

          self.text = 'If the source package does not include license' \

                      ' text(s) as a separate file from upstream, the' \

                      ' packager SHOULD query upstream to include it.'

      '''

      def __init__(self, base):

          GenericShouldCheckBase.__init__(self, base)