PR#290: Ignore some checks for debugsource packages - FedoraReview

FedoraReview

#290 Ignore some checks for debugsource packages

Closed 6 years ago by leamas. Opened 6 years ago by eclipseo.

Unknown source ignore_debugsource_packages into master

Ignore some checks for debugsource packages

Robert-André Mauchin • 6 years ago

195490b

plugins/generic.py

file modified

+2 -2

		`@@ -348,7 +348,7 @@`
		`def run(self):`
		`has_defattr = False`
		`for pkg in self.spec.packages:`
		`- if pkg.endswith('-debuginfo'):`
		`+ if pkg.endswith('-debuginfo') or pkg.endswith('-debugsource'):`
		`# auto-generated %defattr, ignore`
		`continue`
		`for line in self.spec.get_files(pkg):`
		`@@ -1170,7 +1170,7 @@`
		`if path.endswith('.src.rpm'):`
		`return True`
		`pkg = path.rsplit('-', 2)[0]`
		`- return pkg.endswith('-debuginfo')`
		`+ return pkg.endswith('-debuginfo') or pkg.endswith('-debugsource')`

		`bad_owners_by_dir = {}`
		`rpm_files = glob(os.path.join(Mock.resultdir, '*.rpm'))`

plugins/generic_should.py

file modified

+1 -1

		`@@ -284,7 +284,7 @@`
		`for pkg in self.spec.packages:`
		`if pkg == self.spec.base_package:`
		`continue`
		`- for pkg_end in ['debuginfo', '-javadoc', '-doc']:`
		`+ for pkg_end in ['debuginfo', 'debugsource', '-javadoc', '-doc']:`
		`if pkg.endswith(pkg_end):`
		`continue`
		`reqs = ''.join(self.rpms.get(pkg).format_requires)`

eclipseo commented 6 years ago

Currently, fedora-review badly handles the split of -debuginfo packages into -debuginfo and -debugsource packages, it treats -debugsource as normal packages.
This PR puts -debugsource packages on par with -debuginfo ones regarding checks.