#97 CheckSpecName fails to checks spec name
Closed: Fixed None Opened 11 years ago by mizdebsk.

CheckSpecName seems to check local name of the spec file, and not the name of spec included in SRPM. It shouldn't matter what name has spec in the review request as long as spec in the SRPM is named according to the Guidelines.

Example of real review: https://bugzilla.redhat.com/show_bug.cgi?id=846558

Spec URL: http://mizdebsk.fedorapeople.org/review/sonatype-forge-parent/sonatype-forge-parent-12-1.fc19.spec

F-R says:
{{{
[!]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: sonatype-forge-parent-12-1.fc19.spec should be sonatype-forge-
parent.spec
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
}}}

But spec file inside SRPM si named correctly, i.e. sonatype-forge-parent.spec. Only spec URL is different.


Isn't here really two issues:
- That f-r complains about the bad, local filename. I think we could live with this, it's worth mentioning but it's the reviewer who must handle it. It might be an error, or not...
- That a specfile with wrong name in the SRPM isn't detected. This is bad, IMHO

The check for a spec with illegal filename bundled in the srpm is fixed in df3e5a2. I'm closing this bug, since I feel that the warning for the filename in the separate link should be there. It's better to warn one time too many in this case IMHO. In the end, it's the reviewer who decides what to do with it.

Thanks for this report, really. And do feel free to reopen bug, this is still somewhat muddy waters.

Login to comment on this ticket.

Metadata