Ruby Packaging guidelines, section RubyGems say this:
There SHOULD NOT be Requires: ruby(release), unless you want to explicitly specify Ruby version compatibility. The automatically generated dependency on RubyGems (Requires: ruby(rubygems)) is enough.
Requires: ruby(release)
Requires: ruby(rubygems)
Yet, for a gem specfile fulfilling this suggestion, fedora-review complains:
fedora-review
Issues: ======= - Package contains Requires: ruby(release).
The reason is that for non-gem packages, another rule from sectionRuby Compatibility applies, saying that ruby(release) MUST be included. fedora-review only checks this, without distinguishing between gem and non-gem packages.
ruby(release)
To reproduce:
Create a specfile and an srpm with gem2rpm:
gem2rpm
gem2rpm --fetch sync gem2rpm -o rubygem-sync.spec sync-*.gem gem2rpm --srpm sync-*.gem
Run fedora-review on the new specfile: fedora-review -n rubygem-sync
fedora-review -n rubygem-sync
review-rubygem-sync/review.txt
Actual result: Issue Package contains Requires: ruby(release) found.
Expected result: No issues found.
Fixed by #416
Metadata Update from @oturpe: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.