#420 Ruby plugin: gem packages: Incorrect issue about 'Package contains Requires: ruby(release)'
Closed: fixed 2 years ago by oturpe. Opened 2 years ago by oturpe.

Ruby Packaging guidelines, section RubyGems say this:

There SHOULD NOT be Requires: ruby(release), unless you want to explicitly specify Ruby version compatibility. The automatically generated dependency on RubyGems (Requires: ruby(rubygems)) is enough.

Yet, for a gem specfile fulfilling this suggestion, fedora-review complains:

Issues:
=======
- Package contains Requires: ruby(release).

The reason is that for non-gem packages,
another rule from sectionRuby Compatibility applies,
saying that ruby(release) MUST be included.
fedora-review only checks this,
without distinguishing between gem and non-gem packages.

To reproduce:

  1. Create a specfile and an srpm with gem2rpm:

    gem2rpm --fetch sync
    gem2rpm -o rubygem-sync.spec sync-*.gem
    gem2rpm --srpm sync-*.gem
    
  2. Run fedora-review on the new specfile: fedora-review -n rubygem-sync

  3. Observe Issues section of resulting review-rubygem-sync/review.txt.

Actual result:
Issue Package contains Requires: ruby(release) found.

Expected result:
No issues found.


Metadata Update from @oturpe:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata