#40 add a check to see if Conflicts tag exist
Closed: Fixed None Opened 12 years ago by misc.

This patch check if there is a conflict tag in the spec, and so trigger the check about Conflicts.


I am not sure about this. The package might generate conflict with other packages and not be marked as such in the spec file.

I think this is the idea behind this MUST, the reviewer must make sure the package does not conflict with anything else that the packager might have missed.

To me, that's the rule on https://fedoraproject.org/wiki/Packaging:Conflicts that trigger this :

"As a general rule, Fedora packages must NOT contain any usage of the Conflicts: field."

So maybe we can just set it to false if it find a conflict tag, and let it unchecked otherwise ?

( as a side note, the task of checking conflict with all package is IMHO rather dauting and should be done by autoQA, or automated )

Replying to [comment:2 misc]:

To me, that's the rule on https://fedoraproject.org/wiki/Packaging:Conflicts that trigger this :

"As a general rule, Fedora packages must NOT contain any usage of the Conflicts: field."

So maybe we can just set it to false if it find a conflict tag, and let it unchecked otherwise ?

Yeah, I like that idea.

Fixed in r3922689. Thanks for report, feel free to reopen issue if required.

Login to comment on this ticket.

Metadata