Issue #392: When multiple packages satisfy a dependency, and one is deprecated(), it's reported as a problem - FedoraReview

FedoraReview

#392 When multiple packages satisfy a dependency, and one is deprecated(), it's reported as a problem

Opened 3 years ago by churchyard. Modified 2 years ago

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/RIAKMPDDLF6NKLSH7RG7UARNXJ7QGW7G/

Quote:

When running the fedora-review tool on a package that has "BuildRequires: python3dist(pytest)" in it (note there is no version dependency on the pytest package), the review is complaining that:

Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.

Looking in the build log, it is actually using pytest5 though:

+ /usr/bin/python3 -m pytest
============================= test session starts ==============================
platform linux -- Python 3.9.0b1, pytest-5.4.2, py-1.8.0, pluggy-0.13.0

churchyard commented 3 years ago

The problem is that the check calls deps.resolve which in turn calls deps.resolve_one which results in always returning the list of all packages that provide what this package requires.

churchyard commented 3 years ago

As a different approach, we could install the package to mock that built the package and check if any of the installed packages provides deprecated().

churchyard commented 3 years ago

I am working on a temporary workaround.

churchyard commented 3 years ago

https://pagure.io/FedoraReview/pull-request/393

Metadata

Assignee

None

Tags

None

Blocking

None

Depending on

None

Milestone

None

FedoraReview

Source Code

#392 When multiple packages satisfy a dependency, and one is deprecated(), it's reported as a problem Opened 3 years ago by churchyard. Modified 2 years ago

Close issue as:

Metadata

#392 When multiple packages satisfy a dependency, and one is deprecated(), it's reported as a problem

Opened 3 years ago by churchyard. Modified 2 years ago