#39 disable check of debuginfo on pure noarch package
Closed: Fixed None Opened 12 years ago by misc.

this is a patch that disable the checkbox for "check if debug info are relevant" if no arch dependent package are found, as the test would be meaningless.


For this I would check the spec file rather than the rpm files as they might not have been built

But parsing the spec file for all corner cases may be complex, as you can have differents packages under different archs, or some subpackages not being noarch.

Perfect occasion to improve our parser :)

I have really no idea how we perform wrt sub-packages.

I think misc is right here, because:
- A package which doesn't build is basically non-reviewable (it even has an own whiteboard status). No reason to think much about it beyond the fact that it doesn't build.
- Even if the 'parse specfile' approach would be better, it's not really a reason to block this perfectly reasonable patch - if need be, this should be a separate bug.
- Since we are closing up to a release, the revised specfile parser might be to much work in the short term.

Have updated the fixes branch with this patch (e98c35607)

Fixed in 3922689d27479d0. Thanks for reporting, feel free to reopen if required.

Login to comment on this ticket.

Metadata