#346 Error in deps.py/init
Closed: fixed 5 years ago by eclipseo. Opened 5 years ago by eclipseo.

Two people reports the same error with version 7 in bodhi:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-aa89309322

03-18 13:38 root         DEBUG        CheckRpmlintInstalled completed: 55.724 seconds
03-18 13:38 root         DEBUG    Running check: CheckRpmlintDebuginfo
03-18 13:38 root         DEBUG    Run command: rpmlint -f /tmp/tmp1yshmfv5 /home/jstanek/redhat/fedora-review/review-mako/results/mako-debuginfo-1.2-1.fc30.x86_64.rpm
03-18 13:38 root         DEBUG        CheckRpmlintDebuginfo completed: 1.120 seconds
03-18 13:38 root         DEBUG    Running check: CheckInitDeps
03-18 13:38 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 239, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 229, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 352, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 358, in run
    deps.init()
  File "/usr/lib/python3.7/site-packages/FedoraReview/deps.py", line 36, in init
    'dnf'])
  File "/usr/lib64/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib64/python3.7/subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
03-18 13:38 root         ERROR    Exception down the road...(logs in /home/jstanek/.cache/fedora-review.log)
03-18 13:38 root         DEBUG    Report completed:  207.555 seconds

This seems to be an error with the code I added to check Requires in mock:

    try:
        check_output(['mock', '-r', Settings.mock_config, '-qn', 'install',
                      'dnf'])
    except subprocess.CalledProcessError:
        Settings.get_logger().warning(
            "Cannot install dnf, trouble ahead")

I didn't find where the error is. @churchyard can you have a look?


Wait I think I get it, in both case they didn't specify Settings.mock_config

PR: https://pagure.io/FedoraReview/pull-request/347

Could be added as a patch to the current 0.7.0 SPEC.

Metadata Update from @eclipseo:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #347 Merged 5 years ago