#283 fedora-create-review should offer an option in command line to upload into a dedicated folder
Opened 6 years ago by raphgro. Modified 3 years ago

f-c-r actually just uploads sources into root folder of user's space on fedorapeople.org, I would like to have a possibility to group my packages somehow besides there's some other stuff hosted besides review stuff.


This is indeed a needed feature. For now, patches welcome (yes, we will start processinng them...)

I discovered it's possible to configure a (static) upload folder in the settings file, for instance:
% cat ~/.config/fedora-create-review
[fedora-create-review]
upload_target = fedorapeople.org:public_html/review/misc/

It would be great to have an individually named folder for each new upload, maybe as a placeholder ('%pkgname%') in upload_target.

+1, I put my files in a new folder for each package to keep things organised, so this would be a good addition.

How would one go about implementing this? If someone has ideas, I can look into implementing it and opening a PR.

what is the parameter we are talking about ?
can you give some examples ? please
Thank you

For the PR, if you use:

$ cat ~/.config/fedora-create-review 
[fedora-create-review]
upload_target = fedorapeople.org:public_html/@pkgname@/

then create-review will put your spec/srpm into a separate folder that's named after the name of the package.

and without PR ? what we need to upload sources ? please

where is the option to upload without dedicated folder ? "f-c-r actually just uploads sources into root folder of user's space on fedorapeople.org, " how ?

man fedora-review and fedora-review --help don't mention anything about upload target . IMO we also should add some information to man page and --help

aah, we have one script to create review request called fedora-create-review , nice . I will do a PR to improve README

i put up #402 as an updated version of #394 to address this

As I wrote we should add to README.md that we also can automate the creation of a package review with fedora-create-review . Thank you

Good call, put up #403 to update the README

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #394 Closed 3 years ago