https://bugzilla.redhat.com/show_bug.cgi?id=1323966 is my first Fedora package review, and based on the instructions in the wiki, I ran "fedora-review -b 1323966" to invoke the automated checks (this is fedora-review 0.6.0-2 on Fedora 23).
While running that, it emitted the following warning:
INFO: WARNING: Probably non-rawhide buildroot used. Rawhide should be used for most package reviews
I'm happy to use a Rawhide buildroot instead, but it wasn't immediately obvious from the wiki, the error message, "man fedora-review" or "fedora-review --help" what was going wrong and how to fix it.
I eventually worked out that the problem is that /etc/mock/default.cfg defaults to building for the host Fedora version, and that to use a Rawhide buildroot requires running "fedora-review -m /etc/mock/fedora-rawhide-arch.cfg" instead.
arch
Rather than changing any of the documentation or the details of the error message, I'd like to suggest instead changing the default mock config used by fedora-review to be "/etc/mock/fedora-rawhide-arch.cfg" rather than /etc/mock/default.cfg
Folks that specifically want to review in a non-Rawhide environment will still be free to specify an alternative mock configuration, but folks doing normal package reviews will be able to just rely on the defaults.
I don't think is a good idea -it would mean that fedora-review uses other defaults than a plain mock build. The net result is probably more confusion rather than less.
Unless there is more input I will close this bug
Then why is the warning there? The warning makes sense to me: package reviews should generally be targeting Rawhide, so it's reasonable to recommend they be run in a Rawhide buildroot - the default mock configuration on the specific reviewers machine should be irrelevant to the review process.
However, I don't think the warning goes far enough - it should just do the right thing by default, and require people to change it if they want to do the review for a target other than Rawhide.
Alternatively, the warning could be updated to include the exact config option to switch to a Rawhide buildroot:
INFO: WARNING: Probably non-rawhide buildroot used. Rawhide should be used for most package reviews. Specify "-m /etc/mock/fedora-rawhide-arch.cfg" to use a Rawhide buildroot.
HI, fedora-review get's too little love....
The warning message is there because the /etc/mock/default link, which mock uses as default buildroot, does not point to rawhide. This is an old mock upgrade problem which have been discussed in a long discussion and finally patched (don't have the bug at hand).
Anyway, the walk-arounds is to either fix the /etc/mock/default link and/or use the fedora-review -m option to give it an explicit rawhide changeroot. Actually, f-r doesn't do anything wrong here, it's all about mock.
No more input... closing as not-a- bug.
Metadata Update from @leamas: - Issue close_status updated to: None
Metadata Update from @leamas: - Issue close_status updated to: not-a-bug - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.