#244 check for license files in %license and %doc
Closed: Fixed None Opened 7 years ago by flo.

There is an increasing number of packages using the %license for license files.
This is based on: https://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image
And the related FPC-Ticket: https://fedorahosted.org/fpc/ticket/411

It would be great, if fedora-review checks in %license for license files, too.


I've added a patch which provides the check for the icense files in %license and %doc.


Hi Flo,

thanks a lot for your patch.

As far as I understand the new guidelines, it is not needed any more to check %doc for the license text, instead it should be mentioned in %license only. So it seems a simple s|%doc|%license| in the special code line is enough.

Further, it was a discussion to implement the check in rpmlint instead of fedora-review. But it turns out that fedora-review does that already for %doc, so yeah fedora-review is the place for the modification.

Third, maybe consider to file the patch also as a bug against the fedora-review package in Fedora downstream itself.

this seems to be addressed in the devel branch

Hi till!

I knows this is fixed in devel branch. Michel Salims patch is accepted and merged in devel.

So I am closing this ticket.


Login to comment on this ticket.