#233 fedora-review crashes on empty rpms
Closed: Fixed None Opened 8 years ago by zbyszek.

{{{
12-13 14:10 root DEBUG fedora-review 0.5.0 920221d 2013-08-30 11:27:49 +0200 started
12-13 14:10 root DEBUG Command line: /usr/bin/fedora-review -b 1036462 -m fedora-rawhide-x86_64
12-13 14:10 root INFO Processing bugzilla bug: 1036462
12-13 14:10 root INFO Getting .spec and .srpm Urls from : 1036462
12-13 14:10 root DEBUG Active settings after processing options
12-13 14:10 root DEBUG resultdir: None
12-13 14:10 root DEBUG verbose: False
12-13 14:10 root DEBUG no_report: False
12-13 14:10 root DEBUG session_log: /home/zbyszek/.cache/fedora-review.log
12-13 14:10 root DEBUG list_flags: False
12-13 14:10 root DEBUG list_checks: False
12-13 14:10 root DEBUG single: None
12-13 14:10 root DEBUG rpm_spec: False
12-13 14:10 root DEBUG plugins: {}
12-13 14:10 root DEBUG exclude: None
12-13 14:10 root DEBUG configdir: None
12-13 14:10 root DEBUG log_level: 20
12-13 14:10 root DEBUG init_done: True
12-13 14:10 root DEBUG cache: False
12-13 14:10 root DEBUG mock_config: fedora-rawhide-x86_64
12-13 14:10 root DEBUG version: False
12-13 14:10 root DEBUG uniqueext: None
12-13 14:10 root DEBUG flags: []
12-13 14:10 root DEBUG bz_url: https://bugzilla.redhat.com
12-13 14:10 root DEBUG mock_options: --no-cleanup-after --no-clean
12-13 14:10 root DEBUG list_plugins: False
12-13 14:10 root DEBUG _log_config_done: True
12-13 14:10 root DEBUG other_bz: None
12-13 14:10 root DEBUG plugins_arg: None
12-13 14:10 root DEBUG repo: None
12-13 14:10 root DEBUG use_colors: True
12-13 14:10 root DEBUG bug: 1036462
12-13 14:10 root DEBUG prebuilt: False
12-13 14:10 root DEBUG name: None
12-13 14:10 root DEBUG url: None
12-13 14:10 root DEBUG checksum: sha256
12-13 14:10 root DEBUG nobuild: False
12-13 14:10 root DEBUG _con_handler: <logging.StreamHandler object at 0x2264850>
12-13 14:10 root INFO --> SRPM url: http://in.waw.pl/~zbyszek/fedora/unifont-6.3.20131020-3.fc20.src.rpm
12-13 14:10 root INFO --> Spec url: http://in.waw.pl/~zbyszek/fedora/unifont.spec
12-13 14:10 root DEBUG find_urls completed: 6.734
12-13 14:10 root INFO Using review directory: /var/tmp/unitfont-review/1036462-unifont
12-13 14:10 root DEBUG Avoiding init of working mock root
12-13 14:10 root INFO Downloading .spec and .srpm files
12-13 14:10 root DEBUG Url download completed: 5.708
12-13 14:10 root DEBUG Skipping CheckBundledJars in /usr/lib/python2.7/site-packages/FedoraReview/plugins/java.pyc, deprecated by java-check-bundled-jars in /usr/share/fedora-review/scripts/java-check-bundled-jars.sh
12-13 14:10 root DEBUG Skipping CheckExcludeArch in /usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.pyc, deprecated by check-excludearch in /usr/share/fedora-review/scripts/check-excludearch.sh
12-13 14:10 root DEBUG Skipping CheckLargeDocs in /usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.pyc, deprecated by check-large-docs in /usr/share/fedora-review/scripts/check-large-docs.sh
12-13 14:10 root DEBUG --> /var/tmp/unitfont-review/1036462-unifont/upstream : http://ftp.gnu.org/gnu/unifont/unifont-6.3.20131020/unifont-6.3.20131020.tar.gz
12-13 14:10 root INFO Downloading (Source0): http://ftp.gnu.org/gnu/unifont/unifont-6.3.20131020/unifont-6.3.20131020.tar.gz
12-13 14:10 root INFO Running checks and generating report
12-13 14:10 root DEBUG Running check: CheckResultdir
12-13 14:10 root DEBUG CheckResultdir completed: 0.000 seconds
12-13 14:10 root DEBUG Running check: CheckBuild
12-13 14:10 root DEBUG Avoiding init of working mock root
12-13 14:10 root DEBUG Build command: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --resultdir=/var/tmp/unitfont-review/1036462-unifont/results --rebuild /var/tmp/unitfont-review/1036462-unifont/srpm/unifont-6.3.20131020-3.fc20.src.rpm 2>&1 | tee build.log | egrep "Results and/or logs|ERROR"
12-13 14:12 root DEBUG _topdir: /builddir/build
12-13 14:12 root INFO WARNING: Probably non-rawhide buildroot used. Rawhide should be used for most package reviews
12-13 14:12 root INFO Build completed
12-13 14:12 root DEBUG Running: rpm -ql --dump -p /home/zbyszek/fedora/1036462-unifont/results/unifont-6.3.20131020-3.fc20.x86_64.rpm
12-13 14:12 root DEBUG Running: rpm -ql --dump -p /home/zbyszek/fedora/1036462-unifont/results/unifont-fonts-6.3.20131020-3.fc20.noarch.rpm
12-13 14:12 root DEBUG Running: rpm -ql --dump -p /home/zbyszek/fedora/1036462-unifont/results/unifont-debuginfo-6.3.20131020-3.fc20.x86_64.rpm
12-13 14:12 root DEBUG Exception down the road...
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 215, in run
self._do_run(outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 205, in _do_run
self._do_report(outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 90, in _do_report
self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 109, in _run_checks
writedown=not Settings.no_report)
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 389, in run_checks
run_check(name)
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 366, in run_check
check.run()
File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_build.py", line 192, in run
listfiles()
File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_build.py", line 168, in listfiles
dirs, files = deps.listpaths(path)
File "/usr/lib/python2.7/site-packages/FedoraReview/deps.py", line 183, in listpaths
path, mode = line.rsplit(None, 10)[0:5:4]
ValueError: need more than 1 value to unpack
12-13 14:12 root ERROR Exception down the road...(logs in /home/zbyszek/.cache/fedora-review.log)
12-13 14:12 root DEBUG Report completed: 295.588 seconds
}}}

{{{
% rpm -q fedora-review
fedora-review-0.5.0-3.fc20.noarch
}}}

It chokes on the following input:
{{{
% rpm -ql --dump -p results/unifont-debuginfo-6.3.20131020-3.fc20.x86_64.rpm
(contains no files)
}}}


Hm... seems that those links are not available any more. Could you provide a new test case reproducing this (or re-install the links)?

{{{
ERROR: 'Error 404 downloading http://in.waw.pl/~zbyszek/fedora/unifont-6.3.20131221-2.fc20.src.rpm' (logs in ~/.cache/fedora-review.log)

}}}

Sorry, I don't have that file anymore. (I tried recreating it based on git history, but the resulting rpm is not empty).

I created a test (attached for reference), which creates an empty file binary rpm, and fedora-review seems to work fine. Issue seems fixed (although it still says "Cannot parse rpmlint output:").

srpm which generates an empty binary file
frtest-0-1.fc23.src.rpm

Login to comment on this ticket.

Metadata