#225 RubyCheckTestsRun doesn't work properly
Closed: Fixed None Opened 6 years ago by jstribny.

RubyCheckTestsRun check seems to fail to find %check section in RubyGems spec files. In the FedoraReview unit tests all checks are marked as 'fail' even though that tested gems have a %check section and run the test suite. This should be definitely investigated.
1128094


This is bad, and should be fixed to 0.5.0

This is really bad. It's a bug in rpm, which does not export the %check section in the python interface (sigh). I have sent a patch upstream to rpm (Panu), but that will take some time.

In the meantime using spec_file.find_re to make a simple search for %check instead. This means that we match the %check even if it's not expanded due to %if. It's bad, but that's how it is until resolved upstream.

The patch should show up in http://lists.rpm.org/pipermail/rpm-maint/2013-August/thread.html in due time.

Partly fixed in 73d82a9. Leaving bug open until the rpm patch has trickled down (unfortunately, there's no easy way to adapt to the rpm version. The missing %check attribute could be either because of wrong rpm version, or because of a bad spec. No way to know which)

Solution for this when there's a new rpm version will certainly not do it for 0.5.0

Login to comment on this ticket.

Metadata