#210 check spec url file and spec file in srpm are in sync before creating or starting review
Opened 10 years ago by petersen. Modified 7 years ago

It is not uncommon for submitter to have the spec url file and
SRPM spec file out of sync. For me this is a review show-stopper and
I think it would be good if fedora-review refused to review packages
where the spec files differ and also fedora-create-review should not
upload a spec and srpm file pair which is out of sync.

fedora-review seems to use the spec url file when running mock
and yet people normally import the srpm into git, so while
fedora-review does warn that the files are out of sync
I personally think it would be better to insist the spec files
are consistent to avoid run mock on out of sync files.

(In the long term we really want a webapp for Fedora package reviews where
people would just upload srpm's and this problem would /largely/
go away for submissions.)

I tested this with 0.4.0 but I suppose it has not been addressed yet.

See https://bugzilla.redhat.com/show_bug.cgi?id=955847 for the original
report in Fedora bugzilla.


This is really not a defect, but rather revised functionality.

Login to comment on this ticket.

Metadata