After using fedora-review on 3 different packages, I have unfortunately come to the following conclusion: review.txt claims: "n files have unknown license. Detailed output of licensecheck in …/licensecheck.txt" when actually: The number n is actually the number of different licenses, known or unknown, found by licensecheck (not the number of files with unknown license). For each license, only 1 sample file is listed. * In particular, even for "Unknown or generated", only 1 of the suspicious files is listed! This makes it impossible to do a proper audit.
(see also ticket #71, where this feature was introduced)
Hi Kevin :)
Thanks for report. Just to create some common ground: which are the three packages (or their review bugs)?
Provisionary fix in aaac7dc. This is not worst code I have produced, but perhaps on top-10 (a dict called files_by_license was assigned to a variable called files...)
"blushes"
I would appreciate if you could check that new code works better...
Works for me after fix in comment:2. Closing, please feel free to reopen bug if problem persists.
Thanks for filing a valuable ticket!
Login to comment on this ticket.