#19 fedora-review crashes when invoked with --nobuild option
Closed: Fixed None Opened 12 years ago by psabata.

"--nobuild" option doesn't seem to work:

{{{
$ fedora-review -b 766707 --nobuild
Processing review bug : 766707
Getting .spec and .srpm Urls from bug report : 766707
Downloading .spec and .srpm files
Downloading (Source0): http://www.cpan.org/authors/id/X/XI/XIONG/developer-tools/Devel-Comments-v1.1.4.tar.gz
Running checks and generate report

Traceback (most recent call last):
File "/usr/bin/fedora-review", line 202, in <module>
review.run()
File "/usr/bin/fedora-review", line 196, in run
self.do_report()
File "/usr/bin/fedora-review", line 110, in __do_report
self.__do_report_local(self.args.workdir)
File "/usr/bin/fedora-review", line 119, in __do_report_local
self.__run_checks(files_spec[0], files_srpm[0])
File "/usr/bin/fedora-review", line 165, in __run_checks
self.checks.run_checks(output=output)
File "/usr/lib/python2.7/site-packages/FedoraReview/misc.py", line 117, in run_checks
if test.is_applicable() and test.__class
.name \
File "/usr/lib/python2.7/site-packages/FedoraReview/checks/ccpp.py", line 13, in is_applicable
self.sources_have_files('*.c') or \
File "/usr/lib/python2.7/site-packages/FedoraReview/checks/generic.py", line 89, in sources_have_files
sources_files = self.sources.get_files_sources()
File "/usr/lib/python2.7/site-packages/FedoraReview/init.py", line 270, in get_files_sources
self.extract_all()
File "/usr/lib/python2.7/site-packages/FedoraReview/init.py", line 249, in extract_all
source.extract()
File "/usr/lib/python2.7/site-packages/FedoraReview/init.py", line 329, in extract
tar.extractall(self.extract_dir)
File "/usr/lib64/python2.7/tarfile.py", line 2046, in extractall
self.extract(tarinfo, path)
File "/usr/lib64/python2.7/tarfile.py", line 2083, in extract
self._extract_member(tarinfo, os.path.join(path, tarinfo.name))
File "/usr/lib64/python2.7/tarfile.py", line 2159, in _extract_member
self.makefile(tarinfo, targetpath)
File "/usr/lib64/python2.7/tarfile.py", line 2198, in makefile
target = bltn_open(targetpath, "wb")
IOError: [Errno 13] Permission denied: '/var/lib/mock/fedora-rawhide-i386/result/../root/builddir/build/sources/Devel-Comments-v1.1.4/META.yml'
}}}

I don't know why fedora-review wants to write in there. The META.yml file permissions are 0444, (me):(mygroup).


I have a fix here, I'll push it when the git from fedorahosted is fixed to :)

Thanks for reporting.

Login to comment on this ticket.

Metadata