#183 %clean section check is giving wrong results in some cases
Closed: Fixed None Opened 11 years ago by sochotni.

when spec file contains:
{{{
%clean
rm -rf $RPM_BUILD_ROOT
}}}

This is not detected by f-r. I assumed this was because we are searching for
{{{
'rm\s+-[rf][rf]\s+(%{buildroot}|$RPM_BUILD_ROOT)'
}}}
in expanded spec file

However this:
{{{
%clean
rm -rf %{buildroot}
}}}

is caught correctly


Note that we are not really searching for %{buildroot}, the pattern is expanded using rpm.expandMacro first.

Fixed in a2a716e (expression was plain wrong, and lacked the r qualifier).

Login to comment on this ticket.

Metadata