#18 A test description phrasing is not accurate
Closed: Fixed None Opened 12 years ago by psabata.

Current git version of fedora-review automatically marks the following test as passed when a package builds in mock:

"MUST Package successfully compiles and builds into binary rpms on at least one supported architecture."

This is not true for noarch packages.


Hmm, I think it would be a good idea to check if it's a noarch package (i.e. contains "BuildArch:\s*noarch"); if so, just output something like "Package successfully builds".

In all other cases, just change "supported architecture" to "supported primary architecture" and it's going to be perfect :)

Fixed in : http://git.fedorahosted.org/git/?p=FedoraReview.git;a=commit;h=7d06180803782656c98ab5fe0338230db5e8e1ea

The distinction between noarch and arch is duable but I'm not sure it adds so much.

Login to comment on this ticket.

Metadata