#175 javadoc checks: false positives
Closed: Fixed None Opened 11 years ago by mizdebsk.

I was using fedora-review version 0.3.1 b71abc1.

Spec file contains:
{{{
%package javadoc
Summary: Javadocs for %{name}
Group: Documentation
Requires: jpackage-utils
%description javadoc
This package contains the API documentation for %{name}.
}}}

After running fedora-review -b 873738 the following issues appear in the report:

{{{
Issues:
=======
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: 'Requires: %%{name} =' in: %package javadoc
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
[!]: Javadoc subpackages have Requires: jpackage-utils
See: https://fedoraproject.org/wiki/Packaging:Java
}}}

Both issues reported are false-positives. Javadoc packages usually should '''NOT''' have Requires on %{name} and the package under review '''DOES''' have Requires: jpackage-utils.

Full spec file URL: http://olea.org/tmp/omegat-fedora-feature/sequence-library.spec


Hm, trying to reproduce this I run into troubles:
- The description on how to generate Source0 is not complete. I can probably handle this, but it might of course introduce errors.
- I cannot find Source1 and Source2.

Is there any chance you can make the srpm available?

EDIT: sloppy reading (again!). The bug # is in the report,just some lines above. Sorry.

On devel, we get:

{{{
[!]: Fully versioned dependency in subpackages, if present.
Note: Missing: Requires: %{name} = %{version}-%{release} in sequence-
library

}}}
which is plain bull**** , since sequence-library certainly not is a subpackage which should require itself.

I can't reproduce this ATM, but I will try later on another machine with a newer version of F-R.

The devel errors in comment:2 is fixed in 3afb342. Devel also had an issue about not finding %add_maven_depmap in this case, fixed in f702725.

Thanks for bug report! Note that I have not verified what 3.1.1 does or not but rather focused on getting this fixed in devel. There are certainly bugs lurking around here.

Leaving bug open ATM.

Closing bug. Please reopen it if problem persists. And thanks for the bug report, it really helps!

Login to comment on this ticket.

Metadata